From: Sebastian Luther <SebastianLuther@gmx.de>
To: gentoo-portage-dev@lists.gentoo.org
Subject: Re: [gentoo-portage-dev] [PATCH v3] Add repoman check to warn if src_prepare/src_configure are used in EAPI 0/1 and if pkg_pretend is used in EAPI < 4. Fixes bug 379491.
Date: Wed, 15 Jan 2014 22:11:57 +0100 [thread overview]
Message-ID: <52D6F99D.4010308@gmx.de> (raw)
In-Reply-To: <1389819791-17726-1-git-send-email-creffett@gentoo.org>
Am 15.01.2014 22:03, schrieb Chris Reffett:
> + def check_eapi(self, eapi):
> + return eapi in ('0', '1')
> +
Instead of hard coding EAPIs here, you should use the functions in
portage.eapi like eapi_has_src_prepare_and_src_configure().
Same applies for the later part of the patch.
The class names of the checks have the same issue. I understand that
there are existing checks with such names, but that doesn't mean that's
a good idea to keep using them.
You could name them after the phases you're checking for.
Sebastian
prev parent reply other threads:[~2014-01-15 21:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-15 21:03 [gentoo-portage-dev] [PATCH v3] Add repoman check to warn if src_prepare/src_configure are used in EAPI 0/1 and if pkg_pretend is used in EAPI < 4. Fixes bug 379491 Chris Reffett
2014-01-15 21:11 ` Sebastian Luther [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D6F99D.4010308@gmx.de \
--to=sebastianluther@gmx.de \
--cc=gentoo-portage-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox