From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id A73B6138247 for ; Sat, 11 Jan 2014 14:23:37 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id C32CBE0B1A; Sat, 11 Jan 2014 14:23:35 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 29A4AE0AE0 for ; Sat, 11 Jan 2014 14:23:35 +0000 (UTC) Received: from [192.168.1.5] (unknown [184.53.0.112]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: creffett) by smtp.gentoo.org (Postfix) with ESMTPSA id 76DB633F5F7 for ; Sat, 11 Jan 2014 14:23:28 +0000 (UTC) Message-ID: <52D153B5.9060702@gentoo.org> Date: Sat, 11 Jan 2014 09:22:45 -0500 From: Chris Reffett User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-portage-dev@lists.gentoo.org Subject: Re: [gentoo-portage-dev] [PATCH] Check for and report read-only filesystems References: <52D0B588.4010506@gentoo.org> <1389416943.7103.136.camel@big_daddy.dol-sen.ca> In-Reply-To: <1389416943.7103.136.camel@big_daddy.dol-sen.ca> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Archives-Salt: 45613a3f-a476-409b-bff1-b2ac0d30666c X-Archives-Hash: b0fbde13c14a653dcb0a75a5b33710a5 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 01/11/2014 12:09 AM, Brian Dolbec wrote: > On Fri, 2014-01-10 at 22:07 -0500, Chris Reffett wrote: >> Hi all, Attached is a patch to test if Portage is going to write >> to a read-only filesystem and print out the list of filesystems >> that need to be remounted RW. This leaves ${D} intact rather than >> having some files moved before hitting the RO filesystem. Fixes >> bug 378869. Since git.overlays.gentoo.org is down, I haven't had >> the chance to rebase this against latest, but I can resubmit if >> it doesn't cleanly apply. This is my first patch to the list, so >> I apologize if I didn't submit correctly. >> >> Chris Reffett > > > yeah, patch looks good. > > Only thing I didn't like is the return 1 IS that suppose to be > True or sys.exit() value? > > If that is what the module was using, then it's ok. Personally I'm > not a fan of using 0, 1 for False, True. > > But that will come later... > That was just following the style of the rest of the module, for example a collision will return 1. This can be added to the "stuff to be fixed up in future patches" list. Chris Reffett -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iKUEARECAGYFAlLRU7VfFIAAAAAALgAoaXNzdWVyLWZwckBub3RhdGlvbnMub3Bl bnBncC5maWZ0aGhvcnNlbWFuLm5ldEM2NzU5RjUyMDczREJDQkVDQTBDRkE1NERC Nzk1QThBNDI2MTgzNTQACgkQ23laikJhg1QLjQCfSJSpacHoI/IQPS/o+NFJvP6q d8YAmP+RmhoWwa3J1eRNk0BAxX1TtDg= =a7If -----END PGP SIGNATURE-----