Re: [gentoo-portage-dev] [PATCH] Check for and report read-only filesystems

[Chris Reffett <creffett@gentoo.org>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 01/11/2014 12:09 AM, Brian Dolbec wrote:
> On Fri, 2014-01-10 at 22:07 -0500, Chris Reffett wrote:
>> Hi all, Attached is a patch to test if Portage is going to write
>> to a read-only filesystem and print out the list of filesystems
>> that need to be remounted RW. This leaves ${D} intact rather than
>> having some files moved before hitting the RO filesystem. Fixes
>> bug 378869. Since git.overlays.gentoo.org is down, I haven't had
>> the chance to rebase this against latest, but I can resubmit if
>> it doesn't cleanly apply. This is my first patch to the list, so
>> I apologize if I didn't submit correctly.
>> 
>> Chris Reffett
> 
> 
> yeah, patch looks good.
> 
> Only thing I didn't like is the return 1  IS that suppose to be
> True or sys.exit() value?
> 
> If that is what the module was using, then it's ok.  Personally I'm
> not a fan of using 0, 1 for False, True.
> 
> But that will come later...
> 
That was just following the style of the rest of the module, for
example a collision will return 1. This can be added to the "stuff to
be fixed up in future patches" list.

Chris Reffett
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iKUEARECAGYFAlLRU7VfFIAAAAAALgAoaXNzdWVyLWZwckBub3RhdGlvbnMub3Bl
bnBncC5maWZ0aGhvcnNlbWFuLm5ldEM2NzU5RjUyMDczREJDQkVDQTBDRkE1NERC
Nzk1QThBNDI2MTgzNTQACgkQ23laikJhg1QLjQCfSJSpacHoI/IQPS/o+NFJvP6q
d8YAmP+RmhoWwa3J1eRNk0BAxX1TtDg=
=a7If
-----END PGP SIGNATURE-----