public inbox for gentoo-portage-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Alexander Berntsen <alexander@plaimi.net>
To: gentoo-portage-dev@lists.gentoo.org
Subject: Re: [gentoo-portage-dev] Commit Policy
Date: Sat, 11 Jan 2014 04:01:29 +0100	[thread overview]
Message-ID: <52D0B409.8050300@plaimi.net> (raw)
In-Reply-To: <1389350112.7103.133.camel@big_daddy.dol-sen.ca>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Sounds good. A couple of comments,

On 10/01/14 11:35, Brian Dolbec wrote:
> General rule is to submit all patches to this list for review and 
> approval before committing.
s/committ/push

> 1) run pyflakes on your changes to check for faults, misssing 
> imports, variables undefined,...
I recommend getting editor plug-ins that do this for you. syntastic is
great for vim.
- -- 
Alexander
alexander@plaimi.net
http://plaimi.net/~alexander
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iF4EAREIAAYFAlLQtAkACgkQRtClrXBQc7WjhAD/XZtujqvP+UgX1Vg94rb3g2HJ
0BIeCLMj+tWvcj5mzfQA/iuP05SmTJx8taAZrZxdXmSaax1dwHD6De9G+U1TfGYa
=FdTX
-----END PGP SIGNATURE-----


  parent reply	other threads:[~2014-01-11  3:01 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-10 10:35 [gentoo-portage-dev] Commit Policy Brian Dolbec
2014-01-10 17:24 ` Matthew Thode
2014-01-10 18:13 ` Pavel Kazakov
2014-01-11  3:01 ` Alexander Berntsen [this message]
2014-01-13  6:43 ` Sebastian Luther
2014-01-13  7:29   ` Brian Dolbec
2014-01-15  2:19     ` Yixun Lan
2014-01-13 16:37   ` [gentoo-portage-dev] " W. Trevor King
2014-01-15  3:22   ` [gentoo-portage-dev] " Tom Wijsman
2014-01-15  8:42     ` Alexander Berntsen
2014-01-15  3:17 ` Tom Wijsman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52D0B409.8050300@plaimi.net \
    --to=alexander@plaimi.net \
    --cc=gentoo-portage-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox