[gentoo-portage-dev] [PATCH] First draft of a portage pylint.

[gentoo-portage-dev] [PATCH] First draft of a portage pylint.

[antarus]

From: Alec Warner <antarus@gentoo.org>

---
 pylintrc | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)
 create mode 100644 pylintrc

diff --git a/pylintrc b/pylintrc
new file mode 100644
index 0000000..cc15ec4
--- /dev/null
+++ b/pylintrc
@@ -0,0 +1,31 @@
+[MASTER]
+profile=no
+ignore=.git
+persistent=no
+
+[REPORTS]
+# Don't print reports by default, they are spammy. We primarily want linting.
+reports=no
+
+[BASIC]
+# Portage uses stuff like i,j,k for counters, e,ex for exceptions.
+# Don't feel too guilty about adding stuff to here.
+
+# NOTE(antarus): Don't add 'x' here, as it is currently used inappropriately
+# in a ton of legacy code. We want to fix those, then I'd consider adding 'x' and 'y'
+good-names=i,j,k,e,ex
+
+[FORMAT]
+# Portage uses tabs for indenting
+indent-string='\t'
+
+# We have arbitrarily chosen 80 chars.
+# Some lines will be anonying to fix (mostly urls, and other long strings.)
+# You should use inline pylint disable messages to silence those.
+max-line-length=80
+
+# Just make it really large for now.
+max-module-lines=20000
+
+#[MESSAGES CONTROL]
+#disable-msg=W0312
-- 
1.8.1.2

Re: [gentoo-portage-dev] [PATCH] First draft of a portage pylint.

[Alexander Berntsen]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 10/01/14 10:38, antarus@gentoo.org wrote:
> indent-string='\t'
What does this do with respect to mixing tabs and spaces for
formatting? With PEP-8 this is of course not a problem, since it
requires spaces.

> max-module-lines=20000
I think this is terrible, but given the status of our current modules...
I can sympathise with admitting defeat.


Having this is a good idea, for the record. Thanks for the effort.
- -- 
Alexander
alexander@plaimi.net
http://plaimi.net/~alexander
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iF4EAREIAAYFAlLQscYACgkQRtClrXBQc7Ut6wD/aIfDCWNg18oZwwrwliwzIlxB
8HDkBMJAuJoOgL+uGFwA/1Qf2lfknURrOBiW+aoryLervYcBET2f4f4VV/NQjkiz
=TuOS
-----END PGP SIGNATURE-----

Re: [gentoo-portage-dev] [PATCH] First draft of a portage pylint.

[Mike Frysinger]

[-- Attachment #1: Type: Text/Plain, Size: 184 bytes --]

people have been using pyflakes of late.  not that i'm against adding this.

we should have a wrapper script:
$ cat pylint
#!/bin/sh
exec pylint --rcfile "${0%/*}"/pylintrc "$@"
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]