[gentoo-portage-dev] [PATCH] Mention sourced files syntax

[gentoo-portage-dev] [PATCH] Mention sourced files syntax

[Alexander Berntsen]

[-- Attachment #1: Type: text/plain, Size: 625 bytes --]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

I sat down to fix bug #492314, but Sebastian already did. Here's the
man update I did for it though. (Couldn't find anyone with commit
rights available on IRC right now, and I'm soon going to bed, so
posting here.)
- -- 
Alexander
alexander@plaimi.net
http://plaimi.net/~alexander
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iF4EAREIAAYFAlKbz3kACgkQRtClrXBQc7Wb3AEAlh0eEZNhwWLT0HYlQk/vuNqQ
swgznyU8YHkdHRfJ+jUA/35kt18n7TpK110RMkkHdWEKkyecuOjfLG4UJ5bpwzzW
=59oR
-----END PGP SIGNATURE-----

[-- Attachment #2: 0001-man-make.conf.5-Mention-sourced-files-syntax.patch --]
[-- Type: text/x-diff, Size: 1056 bytes --]

From a8e3955829cad53dbfc346a3d5b8b613f4097ff0 Mon Sep 17 00:00:00 2001
From: Alexander Berntsen <alexander@plaimi.net>
Date: Mon, 2 Dec 2013 00:53:25 +0100
Subject: [PATCH] man/make.conf.5: Mention sourced files syntax

---
 man/make.conf.5 | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/man/make.conf.5 b/man/make.conf.5
index ab9b44e..c271d17 100644
--- a/man/make.conf.5
+++ b/man/make.conf.5
@@ -12,7 +12,8 @@ simple shell\-like expansion of the form \fIvar="${var}"\fR, the source
 keyword and variable substitution, but not some of the more advanced BASH
 features like arrays and special parameter expansions. For more details, see
 the Simple lexical analysis documentation:
-\fLhttp://docs.python.org/3/library/shlex.html\fR.
+\fLhttp://docs.python.org/3/library/shlex.html\fR. Note that if you source
+files, they need to be in the same shlex syntax for portage to read them.
 .br
 Portage will check the currently\-defined environment variables
 first for any settings.  If no environment settings are found,
-- 
1.8.3.2

Re: [gentoo-portage-dev] [PATCH] Mention sourced files syntax

[Mike Frysinger]

[-- Attachment #1: Type: Text/Plain, Size: 440 bytes --]

On Sunday 01 December 2013 19:08:26 Alexander Berntsen wrote:
> I sat down to fix bug #492314, but Sebastian already did. Here's the
> man update I did for it though. (Couldn't find anyone with commit
> rights available on IRC right now, and I'm soon going to bed, so
> posting here.)

looks like Brian merged it.  for future patches, please use `git send-email` 
rather than attaching as it makes it a lot easier to review.
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [gentoo-portage-dev] [PATCH] Mention sourced files syntax

[Brian Dolbec]

[-- Attachment #1: Type: text/plain, Size: 791 bytes --]

On Mon, 2013-12-02 at 01:52 -0500, Mike Frysinger wrote:
> On Sunday 01 December 2013 19:08:26 Alexander Berntsen wrote:
> > I sat down to fix bug #492314, but Sebastian already did. Here's the
> > man update I did for it though. (Couldn't find anyone with commit
> > rights available on IRC right now, and I'm soon going to bed, so
> > posting here.)
> 
> looks like Brian merged it.  for future patches, please use `git send-email` 
> rather than attaching as it makes it a lot easier to review.
> -mike


But it was a hell of a lot easier to apply.  It was easy to view inline
in evolution.  Evolution seems to screw up the inline patches.  I had to
wget Sebastians raw email from gmane in order to be able to apply it.

I prefer being able to pull from an online repo. 

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 620 bytes --]

Re: [gentoo-portage-dev] [PATCH] Mention sourced files syntax

[Alexander Berntsen]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

For future reference: please stop CCing me.
- -- 
Alexander
alexander@plaimi.net
http://plaimi.net/~alexander
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iF4EAREIAAYFAlKcczsACgkQRtClrXBQc7WNfwEAtNF6n0KnN1v3g/CBMuzC+4LN
TiBInF1K5tyNkex9dPkBAKF+XodHXAo41oPI3hcvz3oTAuXljgm0p4v/jEsadjLo
=5E8Y
-----END PGP SIGNATURE-----

Re: [gentoo-portage-dev] [PATCH] Mention sourced files syntax

[Mike Frysinger]

[-- Attachment #1: Type: Text/Plain, Size: 1110 bytes --]

On Monday 02 December 2013 05:22:06 Brian Dolbec wrote:
> On Mon, 2013-12-02 at 01:52 -0500, Mike Frysinger wrote:
> > On Sunday 01 December 2013 19:08:26 Alexander Berntsen wrote:
> > > I sat down to fix bug #492314, but Sebastian already did. Here's the
> > > man update I did for it though. (Couldn't find anyone with commit
> > > rights available on IRC right now, and I'm soon going to bed, so
> > > posting here.)
> > 
> > looks like Brian merged it.  for future patches, please use `git
> > send-email` rather than attaching as it makes it a lot easier to review.
> 
> But it was a hell of a lot easier to apply.  It was easy to view inline
> in evolution.  Evolution seems to screw up the inline patches.  I had to
> wget Sebastians raw email from gmane in order to be able to apply it.

that makes no sense.  in evolution, you should just be able to save the e-mail 
as a raw mbox and then apply that.  that's how every e-mail client i've used 
does it.

> I prefer being able to pull from an online repo.

review should happen on the list where everyone else is watching
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [gentoo-portage-dev] [PATCH] Mention sourced files syntax

[Alexander Berntsen]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Please stop CCing me.

- -- 
Alexander
alexander@plaimi.net
http://plaimi.net/~alexander
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iF4EAREIAAYFAlKdfyYACgkQRtClrXBQc7WQOwEAoiQiHJgym5kxQZz0pmUduNN7
h1ZSv7ZlPANYs2btdUsBAJzSM4k6xquBblb+/oTWmqovIhziShOyx1XbhvIxuJT6
=WsPk
-----END PGP SIGNATURE-----