From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id C95BF1381F3 for ; Wed, 24 Jul 2013 16:48:22 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id C0CE8E0A84; Wed, 24 Jul 2013 16:48:18 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 35254E09EC for ; Wed, 24 Jul 2013 16:48:18 +0000 (UTC) Received: from [192.168.26.5] (ip98-164-195-43.oc.oc.cox.net [98.164.195.43]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: zmedico) by smtp.gentoo.org (Postfix) with ESMTPSA id 55DEB33E830; Wed, 24 Jul 2013 16:48:17 +0000 (UTC) Message-ID: <51F00550.8070700@gentoo.org> Date: Wed, 24 Jul 2013 09:48:16 -0700 From: Zac Medico User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-portage-dev@lists.gentoo.org, =?UTF-8?B?VG9tw6HFoSDEjGVjaA==?= Subject: Re: [gentoo-portage-dev] [PATCH] emerge: accept --pkg-format option References: <20130724062813.GG31719@crashnator.suse.cz> <1374647594-3701-1-git-send-email-sleep_walker@suse.cz> In-Reply-To: <1374647594-3701-1-git-send-email-sleep_walker@suse.cz> X-Enigmail-Version: 1.5.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Archives-Salt: f229df62-0af8-42c9-bf05-4adbfe43a985 X-Archives-Hash: 9f3b86e93117101ed3bb92881150bf4c On 07/23/2013 11:33 PM, Tomáš Čech wrote: > Accept --pkg-format option which will override settings of > PORTAGE_BINPKG_FORMAT. Currently takes only one choice of > 'tar' (original gentoo binary package) and 'rpm'. The patch looks good. However, for flexibility, I think we should support multiple formats simultaneously. The EbuildBuild class could use an instance of TaskSequence to execute multiple EbuildBinpkg instances sequentially. Example pseudocode: binpkg_tasks = TaskSequence() for pkg_fmt in settings.get("PORTAGE_BINPKG_FORMAT", "tar").split(): binpkg_tasks.add(EbuildBinpkg(pkg_fmt)) -- Thanks, Zac