public inbox for gentoo-portage-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Zac Medico <zmedico@gentoo.org>
To: gentoo-portage-dev@lists.gentoo.org, "Tomáš Čech" <sleep_walker@suse.cz>
Subject: Re: [gentoo-portage-dev] [PATCH] emerge: accept --pkg-format option
Date: Wed, 24 Jul 2013 09:48:16 -0700	[thread overview]
Message-ID: <51F00550.8070700@gentoo.org> (raw)
In-Reply-To: <1374647594-3701-1-git-send-email-sleep_walker@suse.cz>

On 07/23/2013 11:33 PM, Tomáš Čech wrote:
> Accept --pkg-format option which will override settings of
> PORTAGE_BINPKG_FORMAT. Currently takes only one choice of
> 'tar' (original gentoo binary package) and 'rpm'.

The patch looks good. However, for flexibility, I think we should
support multiple formats simultaneously. The EbuildBuild class could use
an instance of TaskSequence to execute multiple EbuildBinpkg instances
sequentially. Example pseudocode:

binpkg_tasks = TaskSequence()
for pkg_fmt in settings.get("PORTAGE_BINPKG_FORMAT", "tar").split():
    binpkg_tasks.add(EbuildBinpkg(pkg_fmt))

-- 
Thanks,
Zac


  reply	other threads:[~2013-07-24 16:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-24  6:28 [gentoo-portage-dev] emerge: add support for --pkg-format Tomáš Čech
2013-07-24  6:33 ` [gentoo-portage-dev] [PATCH] emerge: accept --pkg-format option Tomáš Čech
2013-07-24 16:48   ` Zac Medico [this message]
2013-07-27 23:09     ` Tomáš Čech
2013-07-30  5:25       ` Zac Medico

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51F00550.8070700@gentoo.org \
    --to=zmedico@gentoo.org \
    --cc=gentoo-portage-dev@lists.gentoo.org \
    --cc=sleep_walker@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox