From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id C50E8138010 for ; Mon, 24 Sep 2012 06:03:48 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 3F320E04D2 for ; Mon, 24 Sep 2012 06:03:48 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id 8E35C21C0B7 for ; Mon, 24 Sep 2012 03:53:11 +0000 (UTC) Received: from [192.168.26.5] (ip98-164-193-252.oc.oc.cox.net [98.164.193.252]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: zmedico) by smtp.gentoo.org (Postfix) with ESMTPSA id EDB8033CBA9; Mon, 24 Sep 2012 03:53:10 +0000 (UTC) Message-ID: <505FD926.1030805@gentoo.org> Date: Sun, 23 Sep 2012 20:53:10 -0700 From: Zac Medico User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:15.0) Gecko/20120901 Thunderbird/15.0 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-portage-dev@lists.gentoo.org CC: Mike Frysinger , Ambroz Bizjak Subject: Re: [gentoo-portage-dev] [PATCH] Implement host dependencies (HDEPEND) and dependencies only in affect when ROOT != / (targetroot flag). References: <1348452403-21471-1-git-send-email-ambrop7@gmail.com> <1348452403-21471-2-git-send-email-ambrop7@gmail.com> <201209232344.59247.vapier@gentoo.org> In-Reply-To: <201209232344.59247.vapier@gentoo.org> X-Enigmail-Version: 1.4.4 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Archives-Salt: 20b78e89-f857-4df6-8763-175c7faca31d X-Archives-Hash: d428b9dd8d737259a4519c6c5616c8c4 On 09/23/2012 08:44 PM, Mike Frysinger wrote: > On Sunday 23 September 2012 22:06:43 Ambroz Bizjak wrote: >> + case "$EAPI" in > > case ${EAPI} in > -mike If somebody manages to corrupt the EAPI with an invalid value containing space, then you can get a bash syntax error there if ${EAPI} is unquoted. Yeah, it's a user error, but it could confuse them even more than they are already if they see the syntax error and think that portage is at fault. Also, we might consider that a corrupt EAPI can come from a binary package (or /var/db/pkg) enviroment.bz2, and so it may not even be the current user who is at fault. -- Thanks, Zac