Re: [gentoo-portage-dev] [PATCH] portage: HTTP if-modified-since and compression

[Zac Medico <zmedico@gentoo.org>]

On 08/01/2012 06:02 PM, Zac Medico wrote:
> On 08/01/2012 04:32 PM, Mark Kubacki wrote:
>> Hi Portage devs,
>>
>> The attached patches fix some issues I've noticed as maintainer and
>> user of Gentoo binhost(s). They're made against master/HEAD and can
>> easily be backported to 2.1*.
>>
>> The first patch enables Portage to skip downloading a remote index if
>> the local copy is recent enough. E.g., the remote index didn't change
>> between to "emerge"-runs. This is done by setting "If-Modified-Since"
>> request-header. The server responds with HTTP code 304 and Portage
>> doesn't even load a single byte of the (large) index file.
>>
>> By the second patch Portage will download remote indices—which are
>> text-files after all—compressed, if the remote server supports that.
>> Although de-compression introduces a small latency, this will save
>> bandwidth and transmission time. If the index needs to be fetched at
>> all, that is (see the patch above).
>>
>> An index' TIMESTAMP entry is set before the corresponding file gets
>> written. If the difference between TIMESTAMP and modification time
>> ("mtime") is greater than or the times span one second, remote index
>> files will be loaded despite the "If-Modified-Since" header. This is
>> because TIMESTAMP of the local copy is compared with the remote index'
>> "mtime". The third patch fixes that by setting "mtime" = TIMESTAMP.
>>
> 
> Thanks, I've applied your patches:
> 
> http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=e06cb6d66db37ac7ab77acf65038b1f770c13c96
> http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=cbebf76d8e5666aad4984f87c2be83d474fe5a7e
> http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=13abe0398fbe724218c8c9ac2597ebe15d7db7e1
> 
> I made a few trivial change in order to make them compatible with
> python3. Also, I made it use the old behavior for protocols other than
> http and https, in order to avoid issues with ftp like this one:
> 
> https://bugs.gentoo.org/show_bug.cgi?id=415579
> 

Fix python2 http password breakage:

http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=fbeb8101b20e232b2e8c55c9554b5fc9c5c72089

BUG: The if_modified_since parameter appears to be ignored when using
http password authentication.
-- 
Thanks,
Zac