From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 6904E138359 for ; Mon, 6 Jul 2020 16:10:40 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 8B835E07B3; Mon, 6 Jul 2020 16:10:39 +0000 (UTC) Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 81EACE07B3 for ; Mon, 6 Jul 2020 16:10:39 +0000 (UTC) Received: by mail-wr1-x444.google.com with SMTP id f18so33609555wrs.0 for ; Mon, 06 Jul 2020 09:10:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding:content-language; bh=SCKDpeCM7mpqQi+kpEX/kCpMxhJSIND6i77V6r3hiw8=; b=Z7zYiugUgDioNAms2BEdIgg800cMJIkunOy2wgbSkc77tw8OerUkka5ODGjDweWPu4 P5eE2K+Oewb+STbK4Wx4/CKfEGAvnC7adIcXtxEY/CnCQLElCICw67NuhXZ6o3DMshVf Pdo6ZmHziBiSO6MIge7pY6vIiftQisWRxHfZvt79lI1hhkxC990pHzD551j/9EnY3zry zQmkQj9b/eljLKrkAwk4ZRpkRWbw8VZWAxeAglja/mAAciaB3rZW/l4ZJjuwK3car6g7 SgsCcR9/dVnVMO5YGGSB6P3w5c68mRTWPmE5xcCQIjLQLbfwZnQLkNZ+NODTnWLw2WPn 1/Dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=SCKDpeCM7mpqQi+kpEX/kCpMxhJSIND6i77V6r3hiw8=; b=QJHw7MOnOhSLgFT7Eu97Nkmhg+NJzO3sKinTOZiZeLONMMrsoiRpZmzyKj08TXSoKO erDYkirR3jYXsukBp5Ru5Z0AP2Gmc6BOlx42UhcU2QEil+Ak3pwDEWVaTKiirkdkhc9j l4BSmIK/sxg84E7sAwF231Nx/kqv/lBzfwI82TShbMxB2AiUplWJALvDOzYslVAbLDNq IwUy39kpeA5cxsSgHG0s0WFW0gE3nL42eYWPGx+gQm1mmygLF43WHZhyp5Jio8NCCrJK qfEd4DVDgcuKcSp0mlyiwL7xzk7YRhCD3VHsIMimcgflkT28w1GooijtdPjGLI9QNwXB Rj1A== X-Gm-Message-State: AOAM532PA9MrgQwnWw91fCaaSkcrwd3AXkiRRdXLM19xIeBBQPJRFWN6 Gzq/F50VYPk3ujhpsqMHrgk1qadr X-Google-Smtp-Source: ABdhPJzPTFfQ8weq3WKBpHz6pLTJrPapO1cagLxPxZzh3q9UOqEi6PU7emMMlafCxgs3wAqfYud5Hw== X-Received: by 2002:a05:6000:12c3:: with SMTP id l3mr10054804wrx.356.1594051838081; Mon, 06 Jul 2020 09:10:38 -0700 (PDT) Received: from [192.168.42.128] (62-11-182-127.dialup.tiscali.it. [62.11.182.127]) by smtp.gmail.com with ESMTPSA id l8sm24466261wrq.15.2020.07.06.09.10.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Jul 2020 09:10:38 -0700 (PDT) Subject: Re: [gentoo-portage-dev] [PATCH 1/3] Add caching to catpkgsplit function To: Michael 'veremitz' Everitt , gentoo-portage-dev@lists.gentoo.org, Sid Spry , Zac Medico References: <20200627063415.936177-1-cshei@google.com> <20200627063415.936177-2-cshei@google.com> <271aeb11-ab17-c27e-9520-119bdbd8da6a@gmail.com> From: Francesco Riosa Message-ID: <4a1f9ee3-a6d9-28a4-7973-6e5cd0da5d5b@gmail.com> Date: Mon, 6 Jul 2020 18:10:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Content-Language: it-IT X-Archives-Salt: 2424158b-b426-47ca-95fd-c12305be26d6 X-Archives-Hash: 28fd40a9b49f0f7798c383a1bf8d6fc8 Il 06/07/20 17:50, Michael 'veremitz' Everitt ha scritto: > On 06/07/20 16:26, Francesco Riosa wrote: >> Il 29/06/20 03:58, Sid Spry ha scritto: >>> There are libraries that provide decorators, etc, for caching and >>> memoization. >>> Have you evaluated any of those? One is available in the standard library: >>> https://docs.python.org/dev/library/functools.html#functools.lru_cache >>> >>> I comment as this would increase code clarity. >>> >> I think portage developers try hard to avoid external dependancies >> I hope hard they do >> >> > I think the key word here is 'external' - anything which is part of the > python standard library is game for inclusion in portage, and has/does > provide much needed optimisation. Many of the issues in portage are > so-called "solved problems" in computing terms, and as such, we should take > advantage of these to improve performance at every available opportunity. > Of course, there are presently only one, two or three key developers able > to make/test these changes (indeed at scale) so progress is often slower > than desirable in current circumstances... > > [sent direct due to posting restrictions...] yes I've replied too fast and didn't notice Sid was referring to _standard_ libraries (not even recent additions) sorry for the noise - Francesco