From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1RGeQB-0003A0-GZ for garchives@archives.gentoo.org; Wed, 19 Oct 2011 22:15:35 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 1D9EE21C06B; Wed, 19 Oct 2011 22:15:08 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id 2B46B21C0BE for ; Wed, 19 Oct 2011 22:14:38 +0000 (UTC) Received: from [192.168.26.4] (ip98-164-193-252.oc.oc.cox.net [98.164.193.252]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: zmedico) by smtp.gentoo.org (Postfix) with ESMTPSA id 54BE01B4001 for ; Wed, 19 Oct 2011 22:14:38 +0000 (UTC) Message-ID: <4E9F4BCC.2030601@gentoo.org> Date: Wed, 19 Oct 2011 15:14:36 -0700 From: Zac Medico User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:7.0.1) Gecko/20111001 Thunderbird/7.0.1 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-portage-dev@lists.gentoo.org Subject: Re: [gentoo-portage-dev] [PATCH 3 of 3] repoman: update copyright on modified files References: <7204f1a467392c31000b.1319054146@nut.cheops.ods.org> In-Reply-To: <7204f1a467392c31000b.1319054146@nut.cheops.ods.org> X-Enigmail-Version: 1.4a1pre Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Archives-Salt: X-Archives-Hash: 950af9edb6896b58ab549033a0cd4e6b On 10/19/2011 12:55 PM, Fabian Groffen wrote: > +def update_copyrights(pkgdir, files, year, pretend): I think update_copyrights() could just as well operate on a single file, and take a single file argument in place of the pkgdir and files arguments. That would simplify the interface a tiny bit. > @@ -651,7 +733,7 @@ > if clold_file is not None: > # clold_lines may contain a saved non-header line > # that we want to write first. > - if clold_lines[-1].strip(): > + if len(clold_lines) > 0 and clold_lines[-1].strip(): > f.write(clold_lines[-1]) Good, this fixes a possible IndexError that I complained about in the previous patch. -- Thanks, Zac