Re: [gentoo-portage-dev] [GLEP59v2 5/5] GLEP59: Change live Manifest2 hashes to SHA256, SHA512, WHIRLPOOL

[Zac Medico <zmedico@gentoo.org>]

On 10/03/2011 04:43 AM, Brian Harring wrote:
> On Mon, Oct 03, 2011 at 02:48:55AM -0700, Zac Medico wrote:
>> After some thought, I like the space delimited approach better. Here's
>> the patch, which retains the ability to remove the manifest hash
>> settings from layout.conf after they become redundant:
>>
>> http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=d9d0606fe01618cc81fb0b862ada91149dad3746
> 
> Suggest you go through the implementation a bit closer; quick look, if 
> the repo no longer uses what portage considers a required hash (atm, 
> sha1), it still will force it in; while that's rather annoying for 
> manifest creation, the validation logic there strikes me as probably 
> being buggy for that case.

This case is only supposed to come up if the user is generating
manifests with a version of portage that has become obsolete for this
type of operation on the repository. I suppose that we could simply make
Manifest.write() raise an exception in this case, and make digestgen()
return unsuccessfully with a suitable error message.

We could also add a layout.conf setting to override
MANIFEST2_REQUIRED_HASH, but that seems unnecessary as long as we stick
to the plan:

  After WHIRLPOOL is supported in stable portage:
  - Add SHA256 and WHIRLPOOL to MANIFEST2_HASH_DEFAULTS.
  - Remove SHA1 and RMD160 from MANIFEST2_HASH_*.
  - Set manifest-hashes in gentoo-x86/metadata/layout.conf as follows:
      manifest-hashes = SHA256 SHA512 WHIRLPOOL

  After WHIRLPOOL is supported in stable portage for at least 1 year:
  - Change MANIFEST2_REQUIRED_HASH to WHIRLPOOL.
  - Remove SHA256 from MANIFEST2_HASH_*.
  - Set manifest-hashes in gentoo-x86/metadata/layout.conf as follows:
      manifest-hashes = SHA512 WHIRLPOOL

  After SHA-3 is approved:
  - Add new hashes to MANIFEST2_HASH_*.

  After SHA-3 is supported in stable portage:
  - Set manifest-hashes in gentoo-x86/metadata/layout.conf as follows:
      manifest-hashes = SHA3 SHA512 WHIRLPOOL

  After layout.conf settings correspond to defaults in stable portage:
  - Remove redundant settings from gentoo-x86/metadata/layout.conf.
-- 
Thanks,
Zac