From: Zac Medico <zmedico@gentoo.org>
To: gentoo-portage-dev@lists.gentoo.org
Subject: Re: [gentoo-portage-dev] [GLEP59v2 5/5] GLEP59: Change live Manifest2 hashes to SHA256, SHA512, WHIRLPOOL
Date: Mon, 03 Oct 2011 02:48:55 -0700 [thread overview]
Message-ID: <4E898507.90302@gentoo.org> (raw)
In-Reply-To: <4E890013.30706@gentoo.org>
On 10/02/2011 05:21 PM, Zac Medico wrote:
> On 10/02/2011 04:22 PM, Brian Harring wrote:
>> On Sun, Oct 02, 2011 at 02:10:09PM -0700, Zac Medico wrote:
> I've implemented it with booleans in this commit:
>
> http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=c8cd3a985cc529299411d7343a11004b7d1330ef
>
>> Should use a space delimited list instead named hashes instead; those
>> being the hashes that should be generated, and that can be /used/.
>> Not in the list, not an acceptable hash (even if a manifest2 carries
>> that data).
>
> Why? Boolean flags are simpler and they work.
After some thought, I like the space delimited approach better. Here's
the patch, which retains the ability to remove the manifest hash
settings from layout.conf after they become redundant:
http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=d9d0606fe01618cc81fb0b862ada91149dad3746
--
Thanks,
Zac
next prev parent reply other threads:[~2011-10-03 9:49 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-01 7:40 [gentoo-portage-dev] [GLEP59v2 0/5] GLEP59: Manifest2 hash types Robin H. Johnson
2011-10-01 7:40 ` [gentoo-portage-dev] [GLEP59v2 1/5] Refactor RMD160 hashlib code for less-hardcoding Robin H. Johnson
2011-10-01 7:40 ` [gentoo-portage-dev] [GLEP59v2 2/5] Manifest2 hash: Whirlpool Robin H. Johnson
2011-10-01 9:41 ` Brian Harring
2011-10-02 6:15 ` Zac Medico
2011-10-01 7:40 ` [gentoo-portage-dev] [GLEP59v2 3/5] Manifest2 hash: SHA512 Robin H. Johnson
2011-10-01 7:40 ` [gentoo-portage-dev] [GLEP59v2 4/5] Manifest2 hash backend provider: mhash Robin H. Johnson
2011-10-01 7:40 ` [gentoo-portage-dev] [GLEP59v2 5/5] GLEP59: Change live Manifest2 hashes to SHA256, SHA512, WHIRLPOOL Robin H. Johnson
2011-10-02 4:40 ` Zac Medico
2011-10-02 6:14 ` Zac Medico
2011-10-02 12:46 ` Robin H. Johnson
2011-10-02 20:39 ` Zac Medico
2011-10-02 20:46 ` Alec Warner
2011-10-02 20:54 ` Robin H. Johnson
2011-10-02 21:10 ` Zac Medico
2011-10-02 23:22 ` Brian Harring
2011-10-03 0:21 ` Zac Medico
2011-10-03 9:48 ` Zac Medico [this message]
2011-10-03 11:43 ` Brian Harring
2011-10-03 14:18 ` Zac Medico
2011-10-05 18:07 ` [gentoo-portage-dev] [GLEP59v2 0/5] GLEP59: Manifest2 hash types Zac Medico
2011-10-05 18:24 ` Robin H. Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E898507.90302@gentoo.org \
--to=zmedico@gentoo.org \
--cc=gentoo-portage-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox