From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1RAFLB-0008Ph-Bc for garchives@archives.gentoo.org; Sun, 02 Oct 2011 06:15:57 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id CC7D421C171; Sun, 2 Oct 2011 06:15:48 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id D106621C131 for ; Sun, 2 Oct 2011 06:15:40 +0000 (UTC) Received: from [192.168.26.4] (ip98-164-193-252.oc.oc.cox.net [98.164.193.252]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: zmedico) by smtp.gentoo.org (Postfix) with ESMTPSA id 614441B4005 for ; Sun, 2 Oct 2011 06:15:40 +0000 (UTC) Message-ID: <4E88018A.9090105@gentoo.org> Date: Sat, 01 Oct 2011 23:15:38 -0700 From: Zac Medico User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:7.0.1) Gecko/20111001 Thunderbird/7.0.1 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-portage-dev@lists.gentoo.org Subject: Re: [gentoo-portage-dev] [GLEP59v2 2/5] Manifest2 hash: Whirlpool References: <1317454855-2794-1-git-send-email-robbat2@gentoo.org> <1317454855-2794-3-git-send-email-robbat2@gentoo.org> <20111001094113.GA3765@localhost> In-Reply-To: <20111001094113.GA3765@localhost> X-Enigmail-Version: 1.4a1pre Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Archives-Salt: X-Archives-Hash: 24c16d9c92331e5d935fd653bcc4137e On 10/01/2011 02:41 AM, Brian Harring wrote: > On Sat, Oct 01, 2011 at 07:40:52AM +0000, Robin H. Johnson wrote: >> From: "Robin H. Johnson" >> >> Provide public-domain implementation of the Whirlpool hash algorithm to >> be used as new Manifest2 hash. >> >> Signed-off-by: Robin H. Johnson >> --- >> pym/portage/checksum.py | 8 ++++++-- >> 1 files changed, 6 insertions(+), 2 deletions(-) >> >> diff --git a/pym/portage/checksum.py b/pym/portage/checksum.py >> index e5455fa..3593686 100644 >> --- a/pym/portage/checksum.py >> +++ b/pym/portage/checksum.py >> @@ -71,6 +71,10 @@ except ImportError: >> >> sha1hash = _generate_hash_function("SHA1", _new_sha1, origin="internal") >> >> +# Bundled WHIRLPOOL implementation >> +from portage.util.whirlpool import new as _new_whirlpool >> +whirlpoolhash = _generate_hash_function("WHIRLPOOL", _new_whirlpool, origin="bundled") >> + > > Likely should shift this to a trailing check if no whirlpool > implementation was found; via this, we can avoid the import unless > it's needed. > ~brian Thanks, that's done now: http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=06ad8911b5790a2ed963fe1b981751ab0a2be8d5 -- Thanks, Zac