* [gentoo-portage-dev] dodoc creating a symlink to distfiles?
@ 2011-04-11 16:04 James Cloos
2011-04-11 17:14 ` Zac Medico
0 siblings, 1 reply; 6+ messages in thread
From: James Cloos @ 2011-04-11 16:04 UTC (permalink / raw
To: gentoo-portage-dev
the recently added sci-math/minisat ebuild has this:
dodoc "${DISTDIR}"/MiniSat.pdf || die
which results in:
sym /usr/share/doc/minisat-2.2.0-r2/MiniSat.pdf -> /usr/portage/distfiles/MiniSat.pdf 1302537422
Is that a portage issue or an issue with the ebuild?
My portage is a few days old; I last merged commit 1d6e6b2fe3b01 from 27 March.
-JimC
--
James Cloos <cloos@jhcloos.com> OpenPGP: 1024D/ED7DAEA6
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [gentoo-portage-dev] dodoc creating a symlink to distfiles? 2011-04-11 16:04 [gentoo-portage-dev] dodoc creating a symlink to distfiles? James Cloos @ 2011-04-11 17:14 ` Zac Medico 2011-04-11 23:32 ` Zac Medico 0 siblings, 1 reply; 6+ messages in thread From: Zac Medico @ 2011-04-11 17:14 UTC (permalink / raw To: gentoo-portage-dev On 04/11/2011 09:04 AM, James Cloos wrote: > the recently added sci-math/minisat ebuild has this: > > dodoc "${DISTDIR}"/MiniSat.pdf || die > > which results in: > > sym /usr/share/doc/minisat-2.2.0-r2/MiniSat.pdf -> /usr/portage/distfiles/MiniSat.pdf 1302537422 > > Is that a portage issue or an issue with the ebuild? > > My portage is a few days old; I last merged commit 1d6e6b2fe3b01 from 27 March. > > -JimC It's a side-effect from this fix which makes dodoc preserve symlinks like doins does in EAPI 4: https://bugs.gentoo.org/show_bug.cgi?id=356461 I guess that we could make doins automatically dereference any symlinks that refer to files absolute paths. For symlinks that refer to directories by absolute paths, we could continue to preserve the symlink as we do now. -- Thanks, Zac ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [gentoo-portage-dev] dodoc creating a symlink to distfiles? 2011-04-11 17:14 ` Zac Medico @ 2011-04-11 23:32 ` Zac Medico 2011-04-12 1:14 ` Zac Medico 0 siblings, 1 reply; 6+ messages in thread From: Zac Medico @ 2011-04-11 23:32 UTC (permalink / raw To: gentoo-portage-dev On 04/11/2011 10:14 AM, Zac Medico wrote: > On 04/11/2011 09:04 AM, James Cloos wrote: >> the recently added sci-math/minisat ebuild has this: >> >> dodoc "${DISTDIR}"/MiniSat.pdf || die >> >> which results in: >> >> sym /usr/share/doc/minisat-2.2.0-r2/MiniSat.pdf -> /usr/portage/distfiles/MiniSat.pdf 1302537422 >> >> Is that a portage issue or an issue with the ebuild? >> >> My portage is a few days old; I last merged commit 1d6e6b2fe3b01 from 27 March. >> >> -JimC > > It's a side-effect from this fix which makes dodoc preserve symlinks > like doins does in EAPI 4: > > https://bugs.gentoo.org/show_bug.cgi?id=356461 > > I guess that we could make doins automatically dereference any symlinks > that refer to files absolute paths. For symlinks that refer to > directories by absolute paths, we could continue to preserve the symlink > as we do now. Here's the patch: http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=2e334d77e3d1836ab6ba5dfc1700e90f9599d4d3 -- Thanks, Zac ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [gentoo-portage-dev] dodoc creating a symlink to distfiles? 2011-04-11 23:32 ` Zac Medico @ 2011-04-12 1:14 ` Zac Medico 2011-04-12 17:38 ` James Cloos 0 siblings, 1 reply; 6+ messages in thread From: Zac Medico @ 2011-04-12 1:14 UTC (permalink / raw To: gentoo-portage-dev On 04/11/2011 04:32 PM, Zac Medico wrote: > On 04/11/2011 10:14 AM, Zac Medico wrote: >> On 04/11/2011 09:04 AM, James Cloos wrote: >>> the recently added sci-math/minisat ebuild has this: >>> >>> dodoc "${DISTDIR}"/MiniSat.pdf || die >>> >>> which results in: >>> >>> sym /usr/share/doc/minisat-2.2.0-r2/MiniSat.pdf -> /usr/portage/distfiles/MiniSat.pdf 1302537422 >>> >>> Is that a portage issue or an issue with the ebuild? >>> >>> My portage is a few days old; I last merged commit 1d6e6b2fe3b01 from 27 March. >>> >>> -JimC >> >> It's a side-effect from this fix which makes dodoc preserve symlinks >> like doins does in EAPI 4: >> >> https://bugs.gentoo.org/show_bug.cgi?id=356461 >> >> I guess that we could make doins automatically dereference any symlinks >> that refer to files absolute paths. For symlinks that refer to >> directories by absolute paths, we could continue to preserve the symlink >> as we do now. > > Here's the patch: > > http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=2e334d77e3d1836ab6ba5dfc1700e90f9599d4d3 Now it's constrained to $PORTAGE_ACTUAL_DISTDIR/ so that we don't stray from PMS: http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=de9a536f470919651e83ece51923594e8605781b -- Thanks, Zac ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [gentoo-portage-dev] dodoc creating a symlink to distfiles? 2011-04-12 1:14 ` Zac Medico @ 2011-04-12 17:38 ` James Cloos 2011-04-12 18:25 ` Zac Medico 0 siblings, 1 reply; 6+ messages in thread From: James Cloos @ 2011-04-12 17:38 UTC (permalink / raw To: gentoo-portage-dev ZM> It's a side-effect from this fix which makes dodoc preserve symlinks ZM> http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=2e334d77e3d1836ab6ba5dfc1700e90f9599d4d3 ZM> http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=de9a536f470919651e83ece51923594e8605781b Confirmed working: >>> /usr/share/doc/minisat-2.2.0-r2/MiniSat.pdf --- replaced sym /usr/share/doc/minisat-2.2.0-r2/MiniSat.pdf -JimC -- James Cloos <cloos@jhcloos.com> OpenPGP: 1024D/ED7DAEA6 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [gentoo-portage-dev] dodoc creating a symlink to distfiles? 2011-04-12 17:38 ` James Cloos @ 2011-04-12 18:25 ` Zac Medico 0 siblings, 0 replies; 6+ messages in thread From: Zac Medico @ 2011-04-12 18:25 UTC (permalink / raw To: gentoo-portage-dev On 04/12/2011 10:38 AM, James Cloos wrote: > ZM> It's a side-effect from this fix which makes dodoc preserve symlinks > > ZM> http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=2e334d77e3d1836ab6ba5dfc1700e90f9599d4d3 > ZM> http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=de9a536f470919651e83ece51923594e8605781b > > Confirmed working: > > >>> /usr/share/doc/minisat-2.2.0-r2/MiniSat.pdf > --- replaced sym /usr/share/doc/minisat-2.2.0-r2/MiniSat.pdf > > -JimC Great! Thanks for testing. -- Thanks, Zac ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-04-12 18:26 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2011-04-11 16:04 [gentoo-portage-dev] dodoc creating a symlink to distfiles? James Cloos 2011-04-11 17:14 ` Zac Medico 2011-04-11 23:32 ` Zac Medico 2011-04-12 1:14 ` Zac Medico 2011-04-12 17:38 ` James Cloos 2011-04-12 18:25 ` Zac Medico
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox