public inbox for gentoo-portage-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Zac Medico <zmedico@gentoo.org>
To: gentoo-portage-dev@lists.gentoo.org
Subject: Re: [gentoo-portage-dev] dodoc creating a symlink to distfiles?
Date: Mon, 11 Apr 2011 18:14:24 -0700	[thread overview]
Message-ID: <4DA3A770.8000901@gentoo.org> (raw)
In-Reply-To: <4DA38F8B.7070706@gentoo.org>

On 04/11/2011 04:32 PM, Zac Medico wrote:
> On 04/11/2011 10:14 AM, Zac Medico wrote:
>> On 04/11/2011 09:04 AM, James Cloos wrote:
>>> the recently added sci-math/minisat ebuild has this:
>>>
>>>    dodoc "${DISTDIR}"/MiniSat.pdf || die
>>>
>>> which results in:
>>>
>>> sym /usr/share/doc/minisat-2.2.0-r2/MiniSat.pdf -> /usr/portage/distfiles/MiniSat.pdf 1302537422
>>>
>>> Is that a portage issue or an issue with the ebuild?
>>>
>>> My portage is a few days old; I last merged commit 1d6e6b2fe3b01 from 27 March.
>>>
>>> -JimC
>>
>> It's a side-effect from this fix which makes dodoc preserve symlinks
>> like doins does in EAPI 4:
>>
>>   https://bugs.gentoo.org/show_bug.cgi?id=356461
>>
>> I guess that we could make doins automatically dereference any symlinks
>> that refer to files absolute paths. For symlinks that refer to
>> directories by absolute paths, we could continue to preserve the symlink
>> as we do now.
> 
> Here's the patch:
> 
> http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=2e334d77e3d1836ab6ba5dfc1700e90f9599d4d3

Now it's constrained to $PORTAGE_ACTUAL_DISTDIR/ so that we don't stray
from PMS:

http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=de9a536f470919651e83ece51923594e8605781b
-- 
Thanks,
Zac



  reply	other threads:[~2011-04-12  1:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-11 16:04 [gentoo-portage-dev] dodoc creating a symlink to distfiles? James Cloos
2011-04-11 17:14 ` Zac Medico
2011-04-11 23:32   ` Zac Medico
2011-04-12  1:14     ` Zac Medico [this message]
2011-04-12 17:38       ` James Cloos
2011-04-12 18:25         ` Zac Medico

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DA3A770.8000901@gentoo.org \
    --to=zmedico@gentoo.org \
    --cc=gentoo-portage-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox