[gentoo-portage-dev] install_qa_check() for hppa64 and ia64-hpux

[gentoo-portage-dev] install_qa_check() for hppa64 and ia64-hpux

[Michael Haubenwallner]

Hi,

have noticed that the "Evaluating misc gcc warnings" QA check does not
know about "hppa64" cpu in bin/misc-functions.sh:
            case ${CHOST} in
        -      alpha*|ia64*|powerpc64*|mips64*|sparc64*|sparcv9*|x86_64*) gentoo_bug=yes ;;
        +      alpha*|hppa64*|ia64*|powerpc64*|mips64*|sparc64*|sparcv9*|x86_64*) gentoo_bug=yes ;;
            esac
        
This was while I was looking why this check blocked merging of gcc-4.3.3
on the 32bit platform CHOST=ia64-hp-hpux* due to:
        warning: implicit declaration of function 'strtok_r'

Yes, ia64-hp-hpux* is a multilib platform with 32bit default - the 64bit
default would have CHOST=ia64w-hp-hpux*.

As we do not do multilib in Prefix, "ia64-hp-hpux*" is 32bit, and I want
to hear your thoughts about this additional line there:
            case ${CHOST} in 
        +      ia64-hp-hpux*) ;; # multilib with 32bit default, 64bit is ia64w-hp-hpux*
               alpha*|hppa64*|ia64*|powerpc64*|mips64*|sparc64*|sparcv9*|x86_64*) gentoo_bug=yes ;;
            esac

Note that each of these are multilib with 32bit default too, although
there is no "64" in the 32bit CHOST:
sparc-*-solaris*  (sparc64-*-solaris*)
i386-*-solaris*   (x86_64-*-solaris*)
powerpc-ibm-aix*  (powerpc64-ibm-aix*)

Thank you!
/haubi/
-- 
Michael Haubenwallner
Gentoo on a different level

Re: [gentoo-portage-dev] install_qa_check() for hppa64 and ia64-hpux

[Mike Frysinger]

[-- Attachment #1: Type: text/plain, Size: 1616 bytes --]

On Tuesday 14 July 2009 04:40:14 Michael Haubenwallner wrote:
> have noticed that the "Evaluating misc gcc warnings" QA check does not
> know about "hppa64" cpu in bin/misc-functions.sh:
> alpha*|hppa64*|ia64*|powerpc64*|mips64*|sparc64*|sparcv9*|x86_64*)
> gentoo_bug=yes ;; esac

looks fine to me -- feel free to add it.  or if you cant, i can throw it in if 
people dont beat me to it.

> This was while I was looking why this check blocked merging of gcc-4.3.3
> on the 32bit platform CHOST=ia64-hp-hpux* due to:
>         warning: implicit declaration of function 'strtok_r'
>
> Yes, ia64-hp-hpux* is a multilib platform with 32bit default - the 64bit
> default would have CHOST=ia64w-hp-hpux*.

the hpux guys created their own 32bit ia64 ELF ABI !?  or they're using x86 
emulation ?  both are wicked stupid ...

> As we do not do multilib in Prefix, "ia64-hp-hpux*" is 32bit, and I want
> to hear your thoughts about this additional line there:
>             case ${CHOST} in
>         +      ia64-hp-hpux*) ;; # multilib with 32bit default, 64bit is
> ia64w-hp-hpux*
> alpha*|hppa64*|ia64*|powerpc64*|mips64*|sparc64*|sparcv9*|x86_64*)
> gentoo_bug=yes ;; esac
>
> Note that each of these are multilib with 32bit default too, although
> there is no "64" in the 32bit CHOST:
> sparc-*-solaris*  (sparc64-*-solaris*)
> i386-*-solaris*   (x86_64-*-solaris*)
> powerpc-ibm-aix*  (powerpc64-ibm-aix*)

the check is to catch the majority of users, and it does.  i dont want to go 
down this rabbit hole.  about we just fix the source code in question and call 
it a day.
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [gentoo-portage-dev] install_qa_check() for hppa64 and ia64-hpux

[Michael Haubenwallner]

On Wed, 2009-07-15 at 10:26 -0400, Mike Frysinger wrote:
> On Tuesday 14 July 2009 04:40:14 Michael Haubenwallner wrote:
> > have noticed that the "Evaluating misc gcc warnings" QA check does not
> > know about "hppa64" cpu in bin/misc-functions.sh:
> > alpha*|hppa64*|ia64*|powerpc64*|mips64*|sparc64*|sparcv9*|x86_64*)
> > gentoo_bug=yes ;; esac
> 
> looks fine to me -- feel free to add it.  or if you cant, i can throw it in if 
> people dont beat me to it.

Should be possible for me, thank you!

> 
> > This was while I was looking why this check blocked merging of gcc-4.3.3
> > on the 32bit platform CHOST=ia64-hp-hpux* due to:
> >         warning: implicit declaration of function 'strtok_r'
> >
> > Yes, ia64-hp-hpux* is a multilib platform with 32bit default - the 64bit
> > default would have CHOST=ia64w-hp-hpux*.
> 
> the hpux guys created their own 32bit ia64 ELF ABI !?  or they're using x86 
> emulation ?  both are wicked stupid ...

Exactly, it is a 32bit ia64 ELF ABI, not x86 (would have different byte
order, and would suggest HP-UX runs on x86 ;) ). It is the default
compiler output (both aCC and gcc) for backwards compatibility.
Did have a discussion with Steve Ellcey (gcc-dev at HP) to add
'ia64w-hp-hpux*' for 64bit default, and leave 'ia64-hp-hpux*' for 32bit
(both multilib-able).

> 
> > As we do not do multilib in Prefix, "ia64-hp-hpux*" is 32bit, and I want
> > to hear your thoughts about this additional line there:
> >             case ${CHOST} in
> >         +      ia64-hp-hpux*) ;; # multilib with 32bit default, 64bit is
> > ia64w-hp-hpux*
> > alpha*|hppa64*|ia64*|powerpc64*|mips64*|sparc64*|sparcv9*|x86_64*)
> > gentoo_bug=yes ;; esac

> the check is to catch the majority of users, and it does.  i dont want to go 
> down this rabbit hole.  about we just fix the source code in question and call 
> it a day.

AFAICS, it is the only exception to "*64*" being 64bit.
But ok, seems I'll have to mask gcc-4.3 even for hppa-hpux anyway.

/haubi/
-- 
Michael Haubenwallner
Gentoo on a different level

Re: [gentoo-portage-dev] install_qa_check() for hppa64 and ia64-hpux

[Michael Haubenwallner]

On Thu, 2009-07-16 at 10:15 +0200, Michael Haubenwallner wrote:
> On Wed, 2009-07-15 at 10:26 -0400, Mike Frysinger wrote:
> > On Tuesday 14 July 2009 04:40:14 Michael Haubenwallner wrote:
> > > have noticed that the "Evaluating misc gcc warnings" QA check does not
> > > know about "hppa64" cpu in bin/misc-functions.sh:
> > > alpha*|hppa64*|ia64*|powerpc64*|mips64*|sparc64*|sparcv9*|x86_64*)
> > > gentoo_bug=yes ;; esac
> > 
> > looks fine to me -- feel free to add it.  or if you cant, i can throw it in if 
> > people dont beat me to it.
> 
> Should be possible for me, thank you!

Nope, don't have permission there.

/haubi/
-- 
Michael Haubenwallner
Gentoo on a different level

Re: [gentoo-portage-dev] install_qa_check() for hppa64 and ia64-hpux

[Mike Frysinger]

[-- Attachment #1: Type: text/plain, Size: 1522 bytes --]

On Thursday 16 July 2009 04:15:50 Michael Haubenwallner wrote:
> On Wed, 2009-07-15 at 10:26 -0400, Mike Frysinger wrote:
> > On Tuesday 14 July 2009 04:40:14 Michael Haubenwallner wrote:
> > > have noticed that the "Evaluating misc gcc warnings" QA check does not
> > > know about "hppa64" cpu in bin/misc-functions.sh:
> > > alpha*|hppa64*|ia64*|powerpc64*|mips64*|sparc64*|sparcv9*|x86_64*)
> > > gentoo_bug=yes ;; esac
> >
> > looks fine to me -- feel free to add it.  or if you cant, i can throw it
> > in if people dont beat me to it.
>
> Should be possible for me, thank you!

ive added to svn, thanks

> > > As we do not do multilib in Prefix, "ia64-hp-hpux*" is 32bit, and I
> > > want to hear your thoughts about this additional line there:
> > >             case ${CHOST} in
> > >         +      ia64-hp-hpux*) ;; # multilib with 32bit default, 64bit
> > > is ia64w-hp-hpux*
> > > alpha*|hppa64*|ia64*|powerpc64*|mips64*|sparc64*|sparcv9*|x86_64*)
> > > gentoo_bug=yes ;; esac
> >
> > the check is to catch the majority of users, and it does.  i dont want to
> > go down this rabbit hole.  about we just fix the source code in question
> > and call it a day.
>
> AFAICS, it is the only exception to "*64*" being 64bit.
> But ok, seems I'll have to mask gcc-4.3 even for hppa-hpux anyway.

the fix here though seems like it should be relatively straight forward ?  
just add a missing #include or #define ?  or are there more gcc-4.3 problems 
than this for that target ?
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [gentoo-portage-dev] install_qa_check() for hppa64 and ia64-hpux

[Michael Haubenwallner]

Mike Frysinger wrote:
>>>> As we do not do multilib in Prefix, "ia64-hp-hpux*" is 32bit, and I
>>>> want to hear your thoughts about this additional line there:
>>>>             case ${CHOST} in
>>>>         +      ia64-hp-hpux*) ;; # multilib with 32bit default, 64bit
>>>> is ia64w-hp-hpux*
>>>> alpha*|hppa64*|ia64*|powerpc64*|mips64*|sparc64*|sparcv9*|x86_64*)
>>>> gentoo_bug=yes ;; esac
>>> the check is to catch the majority of users, and it does.  i dont want to
>>> go down this rabbit hole.  about we just fix the source code in question
>>> and call it a day.
>> AFAICS, it is the only exception to "*64*" being 64bit.
>> But ok, seems I'll have to mask gcc-4.3 even for hppa-hpux anyway.
> 
> the fix here though seems like it should be relatively straight forward ?  
> just add a missing #include or #define ?  or are there more gcc-4.3 problems 
> than this for that target ?

Unfortunately, on <=hpux11.23 it doesn't help to include <string.h>,
as it requires _REENTRANT to be defined to declare strtok_r().
But I don't think defining _REENTRANT inside gcc.c is a really good idea.

However, now I'm wondering how I was able to merge gcc-4.2.4 at all,
as it does have the same warnings...

Maybe I'd better do the same as on AIX and always enable the '-pthread' flag,
also because of this hackery: http://docs.hp.com/en/1896/pthreads.html

Thank you anyway!

/haubi/
-- 
Michael Haubenwallner
Gentoo on a different level