From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([69.77.167.62] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1LXxIR-0004Xd-Lu for garchives@archives.gentoo.org; Fri, 13 Feb 2009 12:37:31 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id D1B14E035F; Fri, 13 Feb 2009 12:37:29 +0000 (UTC) Received: from castor.sshunet.nl (castor.sshunet.nl [145.97.192.41]) by pigeon.gentoo.org (Postfix) with ESMTP id 8FAA7E035F for ; Fri, 13 Feb 2009 12:37:29 +0000 (UTC) Received: from localhost (localhost.localdomain [127.0.0.1]) by castor.sshunet.nl (Postfix) with ESMTP id B6BBF57C053 for ; Fri, 13 Feb 2009 13:37:28 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at castor.sshunet.nl Received: from castor.sshunet.nl ([127.0.0.1]) by localhost (castor.sshunet.nl [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id w0JgnQMu8H+l for ; Fri, 13 Feb 2009 13:37:28 +0100 (CET) Received: from [145.97.223.57] (57pc223.sshunet.nl [145.97.223.57]) by castor.sshunet.nl (Postfix) with ESMTP for ; Fri, 13 Feb 2009 13:37:28 +0100 (CET) Message-ID: <49957791.50501@gentoo.org> Date: Fri, 13 Feb 2009 14:37:21 +0100 From: "Marijn Schouten (hkBst)" User-Agent: Thunderbird 2.0.0.19 (X11/20081231) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-portage-dev@lists.gentoo.org Subject: Re: Fwd: [gentoo-portage-dev] search functionality in emerge References: <5a8c638a0811230417r5bcf912fka14a18edc9c711b6@mail.gmail.com> <49947592.5050109@necoro.eu> <5a8c638a0902121258s7402d9d7l1ad2b9a8ecf9820d@mail.gmail.com> <5a8c638a0902121301g1c37cd8dv1dd83d08c44092ba@mail.gmail.com> In-Reply-To: <5a8c638a0902121301g1c37cd8dv1dd83d08c44092ba@mail.gmail.com> X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Archives-Salt: dd1b4e20-cefe-48b9-b11e-2ecafd9752e1 X-Archives-Hash: 2c9ed17b4cd2ed86053dc1c40df9dfbf -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Emma Strubell wrote: > Hi! > > If I can find an unpickler that can unpickle at a reasonable speed, my > search implementation would be significantly faster than the one currently > in use. I'd show you my code, but I have to admit I'm intimidated by Alec's > recent picking apart of Doug's code! For example, I don't even know how to > use docstrings... The code probably could be cleaned up a lot in general > since I was eventually just trying to get it to work before it was due. Please don't be intimidated by it. Code review is one of the best methods to improve your skills. We all sucked at programming at one time and perhaps we still suck in anything but our favorite language. But if we are to improve ourselves we need to spend a lot of time reading and coding and still we will not always get it right. Furthermore other people learn from our code review, such as you learnt about docstrings. Here[1] is a quick explanation of them. Have fun, Marijn [1]:http://epydoc.sourceforge.net/docstrings.html - -- Sarcasm puts the iron in irony, cynicism the steel. Marijn Schouten (hkBst), Gentoo Lisp project, Gentoo ML , #gentoo-{lisp,ml} on FreeNode -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkmVd5AACgkQp/VmCx0OL2zIFQCgyJYZve1o6DnBBV/HgRV/gWMc 9NkAoLl0M4NX8l+kgWYY3B1dQQtU0/4k =p/Pq -----END PGP SIGNATURE-----