public inbox for gentoo-portage-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Michael A. Smith" <michael@smith-li.com>
To: gentoo-portage-dev@lists.gentoo.org
Subject: Re: [gentoo-portage-dev] equery: deprecate --category filtering in belongs
Date: Sun, 08 Feb 2009 11:11:29 -0500	[thread overview]
Message-ID: <498F0431.1090504@smith-li.com> (raw)
In-Reply-To: <efeb8d230902072305g4dfd300fq3737050180e70f7d@mail.gmail.com>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

If you do drop it, Douglas, I think you should keep it around as a "Warning:
Deprecated" feature for a while before dropping it outright.

That way the users can give feedback via bugzie and their scripts don't break.

- -Michael

Douglas Anderson wrote:
> On Sun, Feb 8, 2009 at 3:30 PM, Brian Harring <ferringb@gmail.com> wrote:
>> patch attached against 0.2.4.2-r1; rough stats follow;
> [snip]
>> Mind you this isn't multiple runs, so the numbers are rough
>> approximations- that said they're fairly representative.
>>
>> Strongly suggest y'all keep category support (although I'll keep on
>> using pquery instead ;).
>>
>> Cheers,
>> ~harring
>>
> 
> Heh, OK I was looking at my local version of equery where category
> filtering IS enabled while I was running tests with old equery, which
> doesn't have it enabled. Thanks for pointing out my stupid mistake,
> Brian. :)
> 
> We can in fact even make it go faster by filtering only cat/pkg before
> it goes through cp_list:
> 
> - 		matches = portage.db["/"]["vartree"].dbapi.cpv_all()
> +		matches = gentoolkit.find_all_installed_packages(lambda x: x.startswith(cat))
> 
> But still... why? When is it useful? Clearly it has never been used up
> until now.
> 
> So I'm still in favor of just dumping it. Seems like complete
> superfluous fluff to me. If anyone would have any real-world use for
> this, I'll clean it up and keep it in. Otherwise I really don't think
> anyone will miss it (especially not Brian :) )
> 
> -Doug
> 
> P.S. I'm strictly talking about belongs here, category filtering in
> all other modules (where it's actually useful and makes sense) is not
> only safe but has been upgraded to take multiple categories, so you
> can now do:
> 
> $ ./equery.py l --category=app-portage,sys-apps port
> [ Searching for port in app-portage, sys-apps ... ]
>  * installed packages
> [I--] [  ] app-portage/portage-utils-0.1.29 (0)
> [I--] [ ~] sys-apps/portage-2.2_rc23 (0)
> 
> 

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iJwEAQECAAYFAkmPBDAACgkQwhlUDnr1of6K6AP/frkkntorPjwHHseoOEK8XzTW
PcvYXafeuJBlSBcna+RPHkvGJdZe6TBJrohXsDx+eTRNi74rdwjIvcNS0LIOx3oV
Ttx/M/onA6nk3iw8qOD5AZDUwTnYkY1eLdsR29hJnoGM2CYUoEWYO9TDQ0DiFdeE
k273HDefsSKxZP43Y/Q=
=KsaQ
-----END PGP SIGNATURE-----



  reply	other threads:[~2009-02-08 16:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-08  5:07 [gentoo-portage-dev] equery: deprecate --category filtering in belongs Douglas Anderson
2009-02-08  5:21 ` Brian Harring
2009-02-08  6:30 ` Brian Harring
2009-02-08  7:05   ` Douglas Anderson
2009-02-08 16:11     ` Michael A. Smith [this message]
2009-02-09  2:26       ` Douglas Anderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=498F0431.1090504@smith-li.com \
    --to=michael@smith-li.com \
    --cc=gentoo-portage-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox