public inbox for gentoo-portage-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Zac Medico <zmedico@gentoo.org>
To: gentoo-portage-dev@lists.gentoo.org, Brian Dolbec <dolsen@gentoo.org>
Subject: Re: [gentoo-portage-dev] [PATCH] _solve_..slot_conflicts: handle forced reinstall (bug 632202)
Date: Fri, 29 Sep 2017 10:32:12 -0700	[thread overview]
Message-ID: <4915e3ac-4567-c230-0f91-30f928d33c9c@gentoo.org> (raw)
In-Reply-To: <20170929061637.07099195@professor-x>


[-- Attachment #1.1: Type: text/plain, Size: 1273 bytes --]

On 09/29/2017 06:16 AM, Brian Dolbec wrote:
> On Fri, 29 Sep 2017 01:15:59 -0700
> Zac Medico <zmedico@gentoo.org> wrote:
> 
>> Fix the slot conflict solver to use the _want_installed_pkg
>> method to identify installed packages that are intended to
>> be reinstalled for some reason (such as @preserved-rebuild).
>>
>> X-Gentoo-bug: 632202
>> X-Gentoo-bug-url: https://bugs.gentoo.org/632202
>> ---
>>  pym/_emerge/depgraph.py | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/pym/_emerge/depgraph.py b/pym/_emerge/depgraph.py
>> index 3b81c5c76..b0149c4dc 100644
>> --- a/pym/_emerge/depgraph.py
>> +++ b/pym/_emerge/depgraph.py
>> @@ -1337,7 +1337,8 @@ class depgraph(object):
>>  					self._dynamic_config._parent_atoms.get(pkg,
>> [])) 
>>  			for parent, atom in all_parent_atoms:
>> -				is_arg_parent = isinstance(parent,
>> AtomArg)
>> +				is_arg_parent = (inst_pkg is not
>> None and
>> +					not
>> self._want_installed_pkg(inst_pkg)) is_non_conflict_parent = parent
>> not in conflict_pkgs and \ parent not in indirect_conflict_pkgs
>>  
> 
> 
> looks good
> 

Thanks, merged:

https://gitweb.gentoo.org/proj/portage.git/commit/?id=d82bf7c0a2cfa9590849aa7fd3ea1257a7f45006
-- 
Thanks,
Zac


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 224 bytes --]

      reply	other threads:[~2017-09-29 17:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-29  8:15 [gentoo-portage-dev] [PATCH] _solve_..slot_conflicts: handle forced reinstall (bug 632202) Zac Medico
2017-09-29 13:16 ` Brian Dolbec
2017-09-29 17:32   ` Zac Medico [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4915e3ac-4567-c230-0f91-30f928d33c9c@gentoo.org \
    --to=zmedico@gentoo.org \
    --cc=dolsen@gentoo.org \
    --cc=gentoo-portage-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox