From: Zac Medico <zmedico@gentoo.org>
To: Zac Medico <zmedico@gentoo.org>, gentoo-portage-dev@lists.gentoo.org
Subject: [gentoo-portage-dev] Re: [PATCH] autounmask: prefer || choices with existing packages (bug 327177)
Date: Mon, 29 Apr 2019 00:51:38 -0700 [thread overview]
Message-ID: <48731dba-da0a-a72d-7722-80cfd3c5917e@gentoo.org> (raw)
In-Reply-To: <20190429073311.10037-1-zmedico@gentoo.org>
[-- Attachment #1.1: Type: text/plain, Size: 563 bytes --]
On 4/29/19 12:33 AM, Zac Medico wrote:
> + # If all choices have unsatisfied deps, fall back to default
> + # autounmask=False behavior.
> + choice = choices[0]
> +
> + if autounmask:
> + # An autounmask choice has been rejected, so clear its
> + # package selections from the cache.
> + self._dynamic_config._filtered_trees[dep_root]["porttree"].dbapi._clear_cache()
In the above case we actually need to revert any autounmask settings
that might have been created. I'll add that and submit an updated patch.
--
Thanks,
Zac
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 981 bytes --]
prev parent reply other threads:[~2019-04-29 7:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-29 7:33 [gentoo-portage-dev] [PATCH] autounmask: prefer || choices with existing packages (bug 327177) Zac Medico
2019-04-29 7:51 ` Zac Medico [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48731dba-da0a-a72d-7722-80cfd3c5917e@gentoo.org \
--to=zmedico@gentoo.org \
--cc=gentoo-portage-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox