From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists.gentoo.org ([140.105.134.102] helo=robin.gentoo.org) by nuthatch.gentoo.org with esmtp (Exim 4.43) id 1E3Bwu-00005D-QH for garchives@archives.gentoo.org; Thu, 11 Aug 2005 12:14:17 +0000 Received: from robin.gentoo.org (localhost [127.0.0.1]) by robin.gentoo.org (8.13.4/8.13.4) with SMTP id j7BCCkjS012101; Thu, 11 Aug 2005 12:12:46 GMT Received: from egr.msu.edu (jeeves.egr.msu.edu [35.9.37.127]) by robin.gentoo.org (8.13.4/8.13.4) with ESMTP id j7BCCjuu001737 for ; Thu, 11 Aug 2005 12:12:46 GMT Received: from [207.72.143.170] (207-72-143-170.dovers_res_net.spartan-net.net [207.72.143.170] (may be forged)) (authenticated bits=0) by egr.msu.edu (8.13.4/8.13.4) with ESMTP id j7BCDZK8006722 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Thu, 11 Aug 2005 08:13:35 -0400 (EDT) Message-ID: <42FB4124.1080502@egr.msu.edu> Date: Thu, 11 Aug 2005 08:14:28 -0400 From: Alec Warner User-Agent: Mozilla Thunderbird 1.0.2 (X11/20050704) X-Accept-Language: en-us, en Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-portage-dev@lists.gentoo.org Subject: Re: [gentoo-portage-dev] PATCH: refactor emerge spinner (#102073) References: <42FADD3A.7020103@gmail.com> In-Reply-To: <42FADD3A.7020103@gmail.com> X-Enigmail-Version: 0.90.2.0 X-Enigmail-Supports: pgp-inline, pgp-mime Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Archives-Salt: 2650a19e-135a-4003-8588-8d3bf2499cdc X-Archives-Hash: 84f5caec0ca0077b80a0385f06b4e12c -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Zac Medico wrote: > http://bugs.gentoo.org/show_bug.cgi?id=102073 > > Author: Zac Medico > > Some refactoring could help make the emerge code more maintainable. I > have written a trivial patch that encapsulates the spinner code into an > object. This patch only reorganizes code and should not cause any > regressions or changes in functionality. > > Comments? > > Zac > I would vote no, but I would hang onto the class. "If it ain't broke, don't fix it" IMHO. Emerge is a beast held together by fine twine, and messing with a stable thing trying to clean it up is at best a fun untested mess. It should be rewritten for the next version and that class may come in handly to make the spinner code ( if there indeed is any ) a bit cleaner. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iQIVAwUBQvtBJGzglR5RwbyYAQKcFw/9GyDPIqCf/gpHmTU1qVcTgsOQ3O5UR7gp WUkqpT3V+EP6VArovpgi/edvZtYcnFyX6V2kDZBXdiBEm2189QkPEWNfQxqyNRwp dq7QfVg9mFDF5mkTdKlSNhl7yO8fibkcY36cSwINNaPaRHZeC04fv56R8kQRr+Zl DXwjN4hMdnKWNM2NQGxIvx/TdfWR0wUSOfvVt6Q9IrVoQ2k2GUzzYuFg3aSF5m8k lThnn5uYYd8kd/cRUiqsycdZdRC+OykTZBN5sxHND8uzZk7lA+ietUWV9EFg6arr Y87cGCkNASg84+vVulR9CilNeYhFsfE7djmfH0ASmgl/9K7YnihVXcwdH9KRHCy5 0cQLacW11/AtxotrhxcGw/w1HawiW26vgpgXMi31o+wIIrCs7L/bJsSE+4X44bX7 4UIaxZRekgOBAIWr1nimdAy5SPMZ51dhpOf/c7kT1NHTK6aoE6m4JJL5wxDvlido Zv1gbDrkKjiM57LOrng4PGT0rWjLt5dhOLSyDhJ6tb6tYD21b74w2PwsDCY7JAew hF5AnxrQEo738cvNrFESSzmqWoINqdT6RYHLNPpKWFTBVO8YbZ7E+G1aySxJSQx+ hDkGeRuWphlRS0ctKpvmCXiEgNdQY5z9O0DpkZ3YKH9KIldIXzI/ddjiheNTKsU9 BpyPl0mRqjY= =+/O5 -----END PGP SIGNATURE----- -- gentoo-portage-dev@gentoo.org mailing list