From: Alec Warner <warnera6@egr.msu.edu>
To: gentoo-portage-dev@lists.gentoo.org
Subject: Re: [gentoo-portage-dev] PATCH: refactor emerge spinner (#102073)
Date: Thu, 11 Aug 2005 08:14:28 -0400 [thread overview]
Message-ID: <42FB4124.1080502@egr.msu.edu> (raw)
In-Reply-To: <42FADD3A.7020103@gmail.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Zac Medico wrote:
> http://bugs.gentoo.org/show_bug.cgi?id=102073
>
> Author: Zac Medico
>
> Some refactoring could help make the emerge code more maintainable. I
> have written a trivial patch that encapsulates the spinner code into an
> object. This patch only reorganizes code and should not cause any
> regressions or changes in functionality.
>
> Comments?
>
> Zac
>
<snip patch>
I would vote no, but I would hang onto the class. "If it ain't broke,
don't fix it" IMHO. Emerge is a beast held together by fine twine, and
messing with a stable thing trying to clean it up is at best a fun
untested mess. It should be rewritten for the next version and that
class may come in handly to make the spinner code ( if there indeed is
any ) a bit cleaner.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org
iQIVAwUBQvtBJGzglR5RwbyYAQKcFw/9GyDPIqCf/gpHmTU1qVcTgsOQ3O5UR7gp
WUkqpT3V+EP6VArovpgi/edvZtYcnFyX6V2kDZBXdiBEm2189QkPEWNfQxqyNRwp
dq7QfVg9mFDF5mkTdKlSNhl7yO8fibkcY36cSwINNaPaRHZeC04fv56R8kQRr+Zl
DXwjN4hMdnKWNM2NQGxIvx/TdfWR0wUSOfvVt6Q9IrVoQ2k2GUzzYuFg3aSF5m8k
lThnn5uYYd8kd/cRUiqsycdZdRC+OykTZBN5sxHND8uzZk7lA+ietUWV9EFg6arr
Y87cGCkNASg84+vVulR9CilNeYhFsfE7djmfH0ASmgl/9K7YnihVXcwdH9KRHCy5
0cQLacW11/AtxotrhxcGw/w1HawiW26vgpgXMi31o+wIIrCs7L/bJsSE+4X44bX7
4UIaxZRekgOBAIWr1nimdAy5SPMZ51dhpOf/c7kT1NHTK6aoE6m4JJL5wxDvlido
Zv1gbDrkKjiM57LOrng4PGT0rWjLt5dhOLSyDhJ6tb6tYD21b74w2PwsDCY7JAew
hF5AnxrQEo738cvNrFESSzmqWoINqdT6RYHLNPpKWFTBVO8YbZ7E+G1aySxJSQx+
hDkGeRuWphlRS0ctKpvmCXiEgNdQY5z9O0DpkZ3YKH9KIldIXzI/ddjiheNTKsU9
BpyPl0mRqjY=
=+/O5
-----END PGP SIGNATURE-----
--
gentoo-portage-dev@gentoo.org mailing list
next prev parent reply other threads:[~2005-08-11 12:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-11 5:08 [gentoo-portage-dev] PATCH: refactor emerge spinner (#102073) Zac Medico
2005-08-11 12:14 ` Alec Warner [this message]
2005-08-11 14:06 ` Jason Stubbs
2005-08-12 5:19 ` [gentoo-portage-dev] the refactoring of emerge, continued... (was PATCH: refactor emerge spinner (#102073)) Zac Medico
2005-08-12 12:36 ` Alec Warner
2005-08-12 20:57 ` Zac Medico
2005-08-12 21:48 ` warnera6
2005-08-12 22:10 ` Marius Mauch
2005-08-12 22:12 ` warnera6
2005-08-12 22:49 ` Zac Medico
2005-08-13 1:06 ` Jason Stubbs
2005-08-13 17:34 ` Zac Medico
2005-08-13 22:25 ` Zac Medico
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42FB4124.1080502@egr.msu.edu \
--to=warnera6@egr.msu.edu \
--cc=gentoo-portage-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox