[gentoo-portage-dev] /etc/make.conf

[gentoo-portage-dev] /etc/make.conf

[Alec Warner]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

In regards to a few bugs reports I want to inquire on the exact format
of make.conf.  It seems some utilities ( euse ) are sourcing
/etc/make.conf.  This is fine for most configurations when users don't
make a lot of changes to the file.  However, in some cases users make
changes that portage will accept but bash will not when sourcing.

Is make.conf meant to be sourcable by bash and we can mark these bugs as
invalid, or do we need to modify the tools to process it and not source
the file.

[1] http://bugs.gentoo.org/show_bug.cgi?id=101416
[2] http://bugs.gentoo.org/show_bug.cgi?id=101486
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iQIVAwUBQvok0mzglR5RwbyYAQLW7A/+Lpkyi93M8SA+HP2BLbqNmroFUTgExfSH
8KhIspTrVskwCkiWwMTOVibNSwB0vXheJ14N6eqpVD7FkU6TEkAprD8G3pWfkYDs
rN6oh9Qw61Dw5HQE8vr7Th1gc02MpnvqAxv52y+9JYeFRI6ne/iAJCcV9H+BPFEW
OcjaF8DA/FZolXJRuGPfzl9QShMa/MvUamIlaVpXowCxsOpN6Vzp2vM8Hw2PD9y1
XgoQR7U8Qz9cyexr8QLeVHg+EK/WliSBA+umxBaRZHBOAcnlnJJp71gp4effmQBG
lQn/+Cw7DH0F9gyNRT//hMaRbikMRkMZu01zyD5ry8D515l6nhDflQHzPxC3W5Ne
57EZjre4Bm1av+Xo1atliCBR2c3xjP+FkZQ+cRD+hWO/ALovAqKBPTcLvqh54tLJ
1QIRE77BaAUXJuC/uClD5GbgTobvjgwXsddhfUvUk03nRVmghn/5jIG19UWfsLzX
cB0LWGTj4ThX8pbjGPaaOuEvcsuXFOHsDQY1emt7tBdCiXMgZsn3RlvpRIJ6lsam
NY884+nFSH/1NUhs5iae6YihemsBUOZxJzyYv3uZa0VQJOVau11j+adqMFkWDQq6
ivXomqv+H7VbT+nNYq5slEkvGidwVqLXYcLGKf9W3hYdE1kAfcDHbHP6EHXxQ6ec
Xnrk02cpqo4=
=vxQl
-----END PGP SIGNATURE-----
-- 
gentoo-portage-dev@gentoo.org mailing list

Re: [gentoo-portage-dev] /etc/make.conf

[Paul Varner]

On Wed, 2005-08-10 at 12:01 -0400, Alec Warner wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> In regards to a few bugs reports I want to inquire on the exact format
> of make.conf.  It seems some utilities ( euse ) are sourcing
> /etc/make.conf.  This is fine for most configurations when users don't
> make a lot of changes to the file.  However, in some cases users make
> changes that portage will accept but bash will not when sourcing.
> 
> Is make.conf meant to be sourcable by bash and we can mark these bugs as
> invalid, or do we need to modify the tools to process it and not source
> the file.

My personal opinion is modify the tools to let portage handle it
utilizing portageq or equivalent.  Here is a snippet of my code from
revdep-rebuild. If that is not possible, then I would state that the
file needs to be sourcable by bash.

# Obey PORTAGE_NICENESS
PORTAGE_NICENESS=$(portageq envvar PORTAGE_NICENESS)
[ ! -z "$PORTAGE_NICENESS" ] && renice $PORTAGE_NICENESS $$ > /dev/null

# Update the incremental variables
using /etc/profile.env, /etc/ld.so.conf,
# portage, and the environment
# Read the incremental variables from environment and portage
PRELIMINARY_SEARCH_DIRS="$SEARCH_DIRS $(portageq envvar SEARCH_DIRS)"
PRELIMINARY_SEARCH_DIRS_MASK="$SEARCH_DIRS_MASK $(portageq envvar
SEARCH_DIRS_MASK)"
PRELIMINARY_LD_LIBRARY_MASK="$LD_LIBRARY_MASK $(portageq envvar
LD_LIBRARY_MASK)"

Regards,
Paul
-- 
gentoo-portage-dev@gentoo.org mailing list

Re: [gentoo-portage-dev] /etc/make.conf

[Colin Kingsley]

Alec Warner wrote:
> Is make.conf meant to be sourcable by bash and we can mark these bugs as
> invalid, or do we need to modify the tools to process it and not source
> the file.

I would prefer to keep make.conf sourceable unless there is some very 
good reason not to. At present, it is essentially identical to bash 
syntax, and sourcing it is much faster than calling portageq. What do we 
gain by allowing quirky syntax that portage understands but bash does not?

--tercel
-- 
gentoo-portage-dev@gentoo.org mailing list

Re: [gentoo-portage-dev] /etc/make.conf

[Marius Mauch]

Paul Varner wrote:
> My personal opinion is modify the tools to let portage handle it
> utilizing portageq or equivalent.  Here is a snippet of my code from
> revdep-rebuild. If that is not possible, then I would state that the
> file needs to be sourcable by bash.

Not possible for euse as it needs not only the final USE but each part 
(global, profile, conf, env) separately.

Marius
-- 
gentoo-portage-dev@gentoo.org mailing list

Re: [gentoo-portage-dev] /etc/make.conf

[Paul Varner]

On Thu, 2005-08-11 at 00:28 +0300, Marius Mauch wrote:
> Paul Varner wrote:
> > My personal opinion is modify the tools to let portage handle it
> > utilizing portageq or equivalent.  Here is a snippet of my code from
> > revdep-rebuild. If that is not possible, then I would state that the
> > file needs to be sourcable by bash.
> 
> Not possible for euse as it needs not only the final USE but each part 
> (global, profile, conf, env) separately.

Sounds like the answer then is that it needs to be a sourceable file :)

Regards,
Paul
-- 
gentoo-portage-dev@gentoo.org mailing list

Re: [gentoo-portage-dev] /etc/make.conf

[Alec Warner]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

If that is the concensus I'll probably fire off a quick message to -dev
telling them and get vapier to touch up the docs a bit on make.conf syntax.

I don't see any reason myself why it shouldn't be 'a bash file' so to
speak :)

Paul Varner wrote:
> On Thu, 2005-08-11 at 00:28 +0300, Marius Mauch wrote:
> 
>>Paul Varner wrote:
>>
>>>My personal opinion is modify the tools to let portage handle it
>>>utilizing portageq or equivalent.  Here is a snippet of my code from
>>>revdep-rebuild. If that is not possible, then I would state that the
>>>file needs to be sourcable by bash.
>>
>>Not possible for euse as it needs not only the final USE but each part 
>>(global, profile, conf, env) separately.
> 
> 
> Sounds like the answer then is that it needs to be a sourceable file :)
> 
> Regards,
> Paul
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iQIVAwUBQvrFuGzglR5RwbyYAQItYg//QeAOtgYqMtgc3Spj65VciYIxpfPt+X0t
rMEu8vmqELGjNySIT6Khbj6ei8NrR1thyaKghHXqvX8mbLHuYg3d/fxc9musNRob
TCdFtj6D1vslVxQv7s8NK/msf+wG+cc5iFBNwrkjjYLh7pZRFcoA5i2PN0WtWFCt
IuAiIVgVFjZyNvYJiDES7wAPpTEOWU0pKrGdCMDbXVA1auwn8HgRLE1tTeM3Hnvc
VkpvarfyZzJ7bCTBkZOFnzX4ppqHeJ3K953TrkEdXAMGk41nXHNDKIIv3yjwl5lr
uTS29lrJDQcLhdH2QMlLrQ70/KXxscn+lWaCrrn6dcPhx17R2WL9RVH1La0qucCs
XQ1dY8b4m3w7PPZ28CRNaSGjYJoMZUMFd/h4C/4WpetphdeiqX+35dyIjCysuor9
73/BnuTkzz4Zi2KyNkt3ne4Ukra2Ss6C8i1Eq+IiI0p+s+lLJZydS7mb6yZviK6d
zsQJdv9O4rOae/ftCmRXctg8ewnUWxx6VTaekXQ5YqIl8TJI1r5KUBDjuQSYrj7X
DWEuctqUWE0Q5eNUiLnVmmsTZhdrJjsXslKZZmVhkvVkDwt2uAwSv9NJpautvEu1
RTrkUbmo335HiBcrMzQF5EYnb0kiuUFu9Om8nZN1iYrGAYD+7q0D+o8plaBRyf4b
7okC55dOie4=
=B+4C
-----END PGP SIGNATURE-----
-- 
gentoo-portage-dev@gentoo.org mailing list