[gentoo-portage-dev] [RFC] Inherit updates settings from master repositories by default

[gentoo-portage-dev] [RFC] Inherit updates settings from master repositories by default

[Arfrever Frehtes Taifersar Arahesis]

[-- Attachment #1: Type: Text/Plain, Size: 1297 bytes --]

Handling of inheritance of updates settings (${repository_location}/profiles/updates/*) is broken
in Portage and triggers DeprecationWarnings.

Current behavior:
- When profiles/updates directory exists in repository X, then only settings from this directory are
  used for packages installed from repository X.
- When profiles/updates directory does not exist in repository X, then only settings from profiles/updates
  directory of repository set in (scheduled for deprecation) 'main-repo' attribute of 'DEFAULT' section
  in repos.conf are used for packages installed from repository X, regardless of value of 'masters' attribute
  in metadata/layout.conf of repository X.

Suggested behavior:
- Support for new 'updates-masters' attribute in metadata/layout.conf.
  If this attribute is not set explicitly, then it defaults to value of 'masters' attribute.
- Settings from profiles/updates directories in repository X and repositories set in 'updates-masters'
  attribute in metadata/layout.conf of repository X are used for packages installed from repository X.

(If a repository containing profiles/updates directory wants to still not inherit updates settings from
master repositories, then it will need 'updates-masters =' in metadata/layout.conf.)

--
Arfrever Frehtes Taifersar Arahesis

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [gentoo-portage-dev] [RFC] Inherit updates settings from master repositories by default

[Sebastian Luther]

Am 01.02.2014 20:38, schrieb Arfrever Frehtes Taifersar Arahesis:
> Handling of inheritance of updates settings
> (${repository_location}/profiles/updates/*) is broken in Portage
> and triggers DeprecationWarnings.
> 
> Current behavior: - When profiles/updates directory exists in
> repository X, then only settings from this directory are used for
> packages installed from repository X. - When profiles/updates
> directory does not exist in repository X, then only settings from
> profiles/updates directory of repository set in (scheduled for
> deprecation) 'main-repo' attribute of 'DEFAULT' section in
> repos.conf are used for packages installed from repository X,
> regardless of value of 'masters' attribute in metadata/layout.conf
> of repository X.
> 
> Suggested behavior: - Support for new 'updates-masters' attribute
> in metadata/layout.conf. If this attribute is not set explicitly,
> then it defaults to value of 'masters' attribute. - Settings from
> profiles/updates directories in repository X and repositories set
> in 'updates-masters' attribute in metadata/layout.conf of
> repository X are used for packages installed from repository X.
> 
> (If a repository containing profiles/updates directory wants to
> still not inherit updates settings from master repositories, then
> it will need 'updates-masters =' in metadata/layout.conf.)
> 

+1

The old behavior doesn't make any sense and the new one is in line
what's done for every other thing inherited from the masters.

> -- Arfrever Frehtes Taifersar Arahesis
> 

Re: [gentoo-portage-dev] [RFC] Inherit updates settings from master repositories by default

[Mike Frysinger]

[-- Attachment #1: Type: text/plain, Size: 916 bytes --]

On Saturday, February 01, 2014 20:38:05 Arfrever Frehtes Taifersar Arahesis 
wrote:
> Suggested behavior:
> - Support for new 'updates-masters' attribute in metadata/layout.conf.

makes sense

>   If this attribute is not set explicitly, then it defaults to value of
> 'masters' attribute.

this i'm not so sure about.  when you have a local overlay, portage complains 
when there are no masters which means most people have just blindly added 
"masters = gentoo".  but if they have packages in there using the old name (on 
purpose), then updates will constantly tromp on that.

at least, there should be one of:
 - one-time automatic migration of existing layout.conf files where we set 
"updates-master =" for them.
 - a warning phase where we complain if the field isn't set, and we default to 
current behavior.  once some time has elapsed, we stop warning and we change 
the default.
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [gentoo-portage-dev] [RFC] Inherit updates settings from master repositories by default

[Sebastian Luther]

Am 05.02.2014 09:03, schrieb Mike Frysinger:
> On Saturday, February 01, 2014 20:38:05 Arfrever Frehtes Taifersar
> Arahesis wrote:
> 
> this i'm not so sure about.  when you have a local overlay, portage
> complains when there are no masters which means most people have
> just blindly added "masters = gentoo".  but if they have packages
> in there using the old name (on purpose), then updates will
> constantly tromp on that.

The old behavior was to always apply the updates from ::gentoo as long
as the repo didn't have its own updates. This means it doesn't matter
if the repo sets the "masters = gentoo" as long as it doesn't contain
updates.

> 
> at least, there should be one of: - one-time automatic migration of
> existing layout.conf files where we set "updates-master =" for
> them.

How do you know if it's the user's repo or a layman repo, where
layout.conf is manged by other people?

> - a warning phase where we complain if the field isn't set, and we
> default to current behavior.  once some time has elapsed, we stop
> warning and we change the default.

Be sure to only hit users which are really affected by the change
(i.e. repos with existing updates and master repos which contain
updates, which affect packages in the repo).

> -mike
> 

Re: [gentoo-portage-dev] [RFC] Inherit updates settings from master repositories by default

[Mike Frysinger]

[-- Attachment #1: Type: text/plain, Size: 1640 bytes --]

On Wednesday, February 05, 2014 19:11:12 Sebastian Luther wrote:
> Am 05.02.2014 09:03, schrieb Mike Frysinger:
> > On Saturday, February 01, 2014 20:38:05 Arfrever Frehtes Taifersar
> > Arahesis wrote:
> > 
> > this i'm not so sure about.  when you have a local overlay, portage
> > complains when there are no masters which means most people have
> > just blindly added "masters = gentoo".  but if they have packages
> > in there using the old name (on purpose), then updates will
> > constantly tromp on that.
> 
> The old behavior was to always apply the updates from ::gentoo as long
> as the repo didn't have its own updates. This means it doesn't matter
> if the repo sets the "masters = gentoo" as long as it doesn't contain
> updates.

ok, i thought it always ignored the gentoo updates dir

> > at least, there should be one of: - one-time automatic migration of
> > existing layout.conf files where we set "updates-master =" for
> > them.
> 
> How do you know if it's the user's repo or a layman repo, where
> layout.conf is manged by other people?

you ask layman.  this isn't difficult.

> > - a warning phase where we complain if the field isn't set, and we
> > default to current behavior.  once some time has elapsed, we stop
> > warning and we change the default.
> 
> Be sure to only hit users which are really affected by the change
> (i.e. repos with existing updates and master repos which contain
> updates, which affect packages in the repo).

doing it based on the current set of affected packages doens't make sense then 
the set of possible updates is constantly changing
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [gentoo-portage-dev] [RFC] Inherit updates settings from master repositories by default

[Mike Frysinger]

[-- Attachment #1: Type: text/plain, Size: 883 bytes --]

On Wednesday, February 05, 2014 03:03:10 Mike Frysinger wrote:
> On Saturday, February 01, 2014 20:38:05 Arfrever wrote:
> >   If this attribute is not set explicitly, then it defaults to value of
> > 'masters' attribute.
> 
> this i'm not so sure about.  when you have a local overlay, portage
> complains when there are no masters which means most people have just
> blindly added "masters = gentoo".  but if they have packages in there using
> the old name (on purpose), then updates will constantly tromp on that.

if portage is already processing updates from the main gentoo-x86 tree in 
repos (that lack an updates/ dir) then i think it simplifies things to:
 - if updates/ exists in the repo and the attribute is not explicitly set, 
then default to "" instead of the value of "masters" and issue a warning 
telling the user to explicit set the attribute
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [gentoo-portage-dev] [RFC] Inherit updates settings from master repositories by default

[Sebastian Luther]

Am 17.02.2014 09:06, schrieb Mike Frysinger:
> On Wednesday, February 05, 2014 19:11:12 Sebastian Luther wrote:
>> Am 05.02.2014 09:03, schrieb Mike Frysinger:
>>> On Saturday, February 01, 2014 20:38:05 Arfrever Frehtes
>>> Taifersar Arahesis wrote:
>>> 
>>> this i'm not so sure about.  when you have a local overlay,
>>> portage complains when there are no masters which means most
>>> people have just blindly added "masters = gentoo".  but if they
>>> have packages in there using the old name (on purpose), then
>>> updates will constantly tromp on that.
>> 
>> The old behavior was to always apply the updates from ::gentoo as
>> long as the repo didn't have its own updates. This means it
>> doesn't matter if the repo sets the "masters = gentoo" as long as
>> it doesn't contain updates.
> 
> ok, i thought it always ignored the gentoo updates dir

At least that's what Arfrever wrote in the first mail as 'old
behavior'. I assume that's correct.

> 
>>> at least, there should be one of: - one-time automatic
>>> migration of existing layout.conf files where we set
>>> "updates-master =" for them.
>> 
>> How do you know if it's the user's repo or a layman repo, where 
>> layout.conf is manged by other people?
> 
> you ask layman.  this isn't difficult.

layman was just an example. The user could as well have cloned a repo
by hand.

When you said "one-time automatic migration" I thought of an update
during portage installation (like it's done for other things). Do you
have something else in mind?

> 
>>> - a warning phase where we complain if the field isn't set, and
>>> we default to current behavior.  once some time has elapsed, we
>>> stop warning and we change the default.
>> 
>> Be sure to only hit users which are really affected by the
>> change (i.e. repos with existing updates and master repos which
>> contain updates, which affect packages in the repo).
> 
> doing it based on the current set of affected packages doens't make
> sense then the set of possible updates is constantly changing

It's true that it may change, but this should only happen very seldom
and only during the transition period.

The idea is that if you don't restrict the warning like that, you're
going to create a lot of noise.

> -mike
>