Re: [gentoo-portage-dev] [PATCH gentoolkit 2/2] eclean: Add option to delete binpkgs with changed deps

[Zac Medico <zmedico@gentoo.org>]

[-- Attachment #1.1: Type: text/plain, Size: 1000 bytes --]

On 2/20/20 9:29 PM, Matt Turner wrote:
> @@ -564,7 +577,22 @@ def findPackages(
>  
>          # Exclude if binpkg exists in the porttree and not --deep
>          if not destructive and port_dbapi.cpv_exists(cpv):
> -            continue
> +            if not options['changed-deps']:
> +                continue
> +
> +            uselist = bin_dbapi.aux_get(cpv, ['USE'])[0].split()
> +            all_equal = True
> +
> +            for k in ('RDEPEND', 'PDEPEND'):
> +                binpkg_deps = bin_dbapi.aux_get(cpv, [k])
> +                ebuild_deps = port_dbapi.aux_get(cpv, [k])
> +
> +                if not _deps_equal(binpkg_deps, ebuild_deps, cpv.eapi, uselist):
> +                    all_equal = False
> +                    break
> +
> +            if all_equal:
> +                continue

If all_equal is True, then none of the other filters have an opportunity
to add this package to the dead_binpkgs set. That's not good is it?
-- 
Thanks,
Zac


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 981 bytes --]