From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id E1F2E1382C5 for ; Mon, 5 Feb 2018 22:45:55 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id EE236E0A68; Mon, 5 Feb 2018 22:45:54 +0000 (UTC) Received: from smtp.laposte.net (smtpoutz28.laposte.net [194.117.213.103]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 95F27E0A64 for ; Mon, 5 Feb 2018 22:45:54 +0000 (UTC) Received: from smtp.laposte.net (localhost [127.0.0.1]) by lpn-prd-vrout016 (Postfix) with ESMTP id 160F811C62A for ; Mon, 5 Feb 2018 23:45:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=laposte.net; s=mail0; t=1517870753; bh=LvJh3ZNmoh5PKcQp4Skh9eXTA3D0SSb0F9tNRyf5WXE=; h=Subject:To:References:From:Date:In-Reply-To; b=InEpCNawi7tlRG0h0sHLAKjK+u05MNwBziWOv8vCOXV3ArYn0GhrgQE851+4Ych/P NiKU2sYrVqR7EOM0N2Yrhp3gCVzQbaFue4Oy71pAb21cJbo+XslHiHmTnVbh+WAMd6 4dmkasVZc7U4za/lEWcIQAYwl288DFO+zO67KOjT3OEow/Dz2chTY2niyS3rmbbEw8 rdAaGkQBnuOW07AkuZau43HFo6TG93GszddMjiotY5MG5EpUakqOz4yvyh1pTj4EGn aoVPKaOwlgCvGvWCJm+t1KmqOI8RHiVtZJu7NbZ6EbbfGspimNuDScLng0s8wgulb/ jUdEMHsVZz3UQ== Received: from smtp.laposte.net (localhost [127.0.0.1]) by lpn-prd-vrout016 (Postfix) with ESMTP id 0F6E911C639 for ; Mon, 5 Feb 2018 23:45:52 +0100 (CET) Received: from lpn-prd-vrin001 (lpn-prd-vrin001.prosodie [10.128.63.2]) by lpn-prd-vrout016 (Postfix) with ESMTP id EA91B11C5F0 for ; Mon, 5 Feb 2018 23:45:51 +0100 (CET) Received: from lpn-prd-vrin001 (localhost [127.0.0.1]) by lpn-prd-vrin001 (Postfix) with ESMTP id D8FB036B73F for ; Mon, 5 Feb 2018 23:45:51 +0100 (CET) Received: from [192.168.1.134] (52.224.78.188.dynamic.jazztel.es [188.78.224.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lpn-prd-vrin001 (Postfix) with ESMTPSA id 8CDE236B735 for ; Mon, 5 Feb 2018 23:45:51 +0100 (CET) Subject: Re: [gentoo-portage-dev] [PATCH 1/2] portage.package.ebuild.config: Rename iuse_implicit -> iuse_effective To: gentoo-portage-dev@lists.gentoo.org References: <20180204134046.26868-1-mgorny@gentoo.org> From: Michael Lienhardt Message-ID: <32031327-d440-cf6a-2b20-dfb7625155e4@laposte.net> Date: Mon, 5 Feb 2018 23:46:01 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 In-Reply-To: <20180204134046.26868-1-mgorny@gentoo.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Language: it-IT Content-Transfer-Encoding: 8bit X-VR-FullState: 0 X-VR-Score: 0 X-VR-Cause-1: gggruggvucftvghtrhhoucdtuddrgedtfedrudefgddtudcutefuodetggdotefrodftvfcurfhrohhf X-VR-Cause-2: ihhlvgemucfntefrqffuvffgnecuuegrihhlohhuthemucehtddtnecunecujfgurhepuffvfhfhkfff X-VR-Cause-3: fgggjggtgfesthekredttdefjeenucfhrhhomhepofhitghhrggvlhcunfhivghnhhgrrhguthcuoehm X-VR-Cause-4: ihgthhgrvghlrdhlihgvnhhhrghrughtsehlrghpohhsthgvrdhnvghtqeenucfkphepudekkedrjeek X-VR-Cause-5: rddvvdegrdehvdenucfrrghrrghmpehmohguvgepshhmthhpohhuthdphhgvlhhopegludelvddrudei X-VR-Cause-6: kedruddrudefgegnpdhinhgvthepudekkedrjeekrddvvdegrdehvddpmhgrihhlfhhrohhmpehmihgt X-VR-Cause-7: hhgrvghlrdhlihgvnhhhrghrughtsehlrghpohhsthgvrdhnvghtpdhrtghpthhtohepghgvnhhtohho X-VR-Cause-8: qdhpohhrthgrghgvqdguvghvsehlihhsthhsrdhgvghnthhoohdrohhrghenucevlhhushhtvghrufhi X-VR-Cause-9: iigvpedt X-VR-AvState: No X-VR-State: 0 X-VR-State: 0 X-Archives-Salt: 403aa4bb-4c06-4d1b-9a1b-6a58093da9be X-Archives-Hash: 445826fd4bfc8a300702b5ddd2fe05f6 Is the IUSE_IMPLICIT variable in the make.defaults also changed into IUSE_EFFECTIVE? I'm sorry if this question was already discussed/answered somewhere else. Michael Il 04/02/2018 14:40, Michał Górny ha scritto: > Rename the iuse_implicit variable used in USE_EXPAND handling to > iuse_effective, since that is what is actually passed there. Correct > naming makes figuring out what the function does much easier. > --- > pym/portage/package/ebuild/config.py | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/pym/portage/package/ebuild/config.py b/pym/portage/package/ebuild/config.py > index 5624e86d3..35cf4f614 100644 > --- a/pym/portage/package/ebuild/config.py > +++ b/pym/portage/package/ebuild/config.py > @@ -1307,13 +1307,13 @@ class config(object): > """ > > def __init__(self, settings, unfiltered_use, > - use, usemask, iuse_implicit, > + use, usemask, iuse_effective, > use_expand_split, use_expand_dict): > self._settings = settings > self._unfiltered_use = unfiltered_use > self._use = use > self._usemask = usemask > - self._iuse_implicit = iuse_implicit > + self._iuse_effective = iuse_effective > self._use_expand_split = use_expand_split > self._use_expand_dict = use_expand_dict > > @@ -1331,7 +1331,7 @@ class config(object): > if has_wildcard: > var_split = [ x for x in var_split if x != "*" ] > has_iuse = set() > - for x in self._iuse_implicit: > + for x in self._iuse_effective: > if x[:prefix_len] == prefix: > has_iuse.add(x[prefix_len:]) > if has_wildcard: >