public inbox for gentoo-portage-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Michael Lienhardt <michael.lienhardt@laposte.net>
To: gentoo-portage-dev@lists.gentoo.org
Subject: Re: [gentoo-portage-dev] [PATCH 1/2] portage.package.ebuild.config: Rename iuse_implicit -> iuse_effective
Date: Mon, 5 Feb 2018 23:46:01 +0100	[thread overview]
Message-ID: <32031327-d440-cf6a-2b20-dfb7625155e4@laposte.net> (raw)
In-Reply-To: <20180204134046.26868-1-mgorny@gentoo.org>

Is the IUSE_IMPLICIT variable in the make.defaults also changed into IUSE_EFFECTIVE?

I'm sorry if this question was already discussed/answered somewhere else.

Michael

Il 04/02/2018 14:40, Michał Górny ha scritto:
> Rename the iuse_implicit variable used in USE_EXPAND handling to
> iuse_effective, since that is what is actually passed there. Correct
> naming makes figuring out what the function does much easier.
> ---
>   pym/portage/package/ebuild/config.py | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/pym/portage/package/ebuild/config.py b/pym/portage/package/ebuild/config.py
> index 5624e86d3..35cf4f614 100644
> --- a/pym/portage/package/ebuild/config.py
> +++ b/pym/portage/package/ebuild/config.py
> @@ -1307,13 +1307,13 @@ class config(object):
>   		"""
>   
>   		def __init__(self, settings, unfiltered_use,
> -			use, usemask, iuse_implicit,
> +			use, usemask, iuse_effective,
>   			use_expand_split, use_expand_dict):
>   			self._settings = settings
>   			self._unfiltered_use = unfiltered_use
>   			self._use = use
>   			self._usemask = usemask
> -			self._iuse_implicit = iuse_implicit
> +			self._iuse_effective = iuse_effective
>   			self._use_expand_split = use_expand_split
>   			self._use_expand_dict = use_expand_dict
>   
> @@ -1331,7 +1331,7 @@ class config(object):
>   			if has_wildcard:
>   				var_split = [ x for x in var_split if x != "*" ]
>   			has_iuse = set()
> -			for x in self._iuse_implicit:
> +			for x in self._iuse_effective:
>   				if x[:prefix_len] == prefix:
>   					has_iuse.add(x[prefix_len:])
>   			if has_wildcard:
> 


  parent reply	other threads:[~2018-02-05 22:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-04 13:40 [gentoo-portage-dev] [PATCH 1/2] portage.package.ebuild.config: Rename iuse_implicit -> iuse_effective Michał Górny
2018-02-04 13:40 ` [gentoo-portage-dev] [PATCH 2/2] portage.package.ebuild.config: Always export filtered USE_EXPAND vars Michał Górny
2018-02-05  2:48   ` Zac Medico
2018-02-05 22:46 ` Michael Lienhardt [this message]
2018-02-05 23:05   ` [gentoo-portage-dev] [PATCH 1/2] portage.package.ebuild.config: Rename iuse_implicit -> iuse_effective Zac Medico
2018-02-06  8:36     ` Michael Lienhardt
  -- strict thread matches above, loose matches on Subject: below --
2016-05-20 22:26 Michał Górny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=32031327-d440-cf6a-2b20-dfb7625155e4@laposte.net \
    --to=michael.lienhardt@laposte.net \
    --cc=gentoo-portage-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox