From: Zac Medico <zmedico@gentoo.org>
To: Aaron Bauman <bman@gentoo.org>, gentoo-portage-dev@lists.gentoo.org
Cc: Sam James <sam@gentoo.org>, Zac Medico <zmedico@gentoo.org>
Subject: [gentoo-portage-dev] Re: [PATCH] lib/portage/repository/config.py: fix trailing-comma-tuple
Date: Tue, 4 Aug 2020 20:16:56 -0700 [thread overview]
Message-ID: <267bcf61-0d51-2bc6-588e-8e82a2b34a38@gentoo.org> (raw)
In-Reply-To: <20200805023551.681237-1-bman@gentoo.org>
[-- Attachment #1.1: Type: text/plain, Size: 1573 bytes --]
On 8/4/20 7:35 PM, Aaron Bauman wrote:
> * This fixes the one instance of trailing-comma-tuple in the repo
> * A tuple does need created, but lets do so inside of parentheses as
> expected
>
> Suggested-By: Sam James <sam@gentoo.org>
> Suggested-By: Zac Medico <zmedico@gentoo.org>
> Signed-off-by: Aaron Bauman <bman@gentoo.org>
> ---
> lib/portage/repository/config.py | 2 +-
> pylintrc | 3 ++-
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/lib/portage/repository/config.py b/lib/portage/repository/config.py
> index 0f3e582f8..f7c956dd8 100644
> --- a/lib/portage/repository/config.py
> +++ b/lib/portage/repository/config.py
> @@ -871,7 +871,7 @@ class RepoConfigLoader:
> continue
> if repo.masters is None:
> if self.mainRepo() and repo_name != self.mainRepo().name:
> - repo.masters = self.mainRepo(),
> + repo.masters = (self.mainRepo(),)
> else:
> repo.masters = ()
> else:
> diff --git a/pylintrc b/pylintrc
> index 337311daa..5e13f714c 100644
> --- a/pylintrc
> +++ b/pylintrc
> @@ -21,7 +21,8 @@ enable=
> redefined-builtin,
> reimported,
> relative-beyond-top-level,
> - trailing-newlines,
> + trailing-comma-tuple,
> + trailing-newlines,
> trailing-whitespace,
> unexpected-line-ending-format,
> unnecessary-semicolon,
>
Thanks, merged:
https://gitweb.gentoo.org/proj/portage.git/commit/?id=3e0063094ce656a173f46a9a4837260322769f2e
--
Thanks,
Zac
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 981 bytes --]
prev parent reply other threads:[~2020-08-05 3:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-05 2:35 [gentoo-portage-dev] [PATCH] lib/portage/repository/config.py: fix trailing-comma-tuple Aaron Bauman
2020-08-05 3:16 ` Zac Medico [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=267bcf61-0d51-2bc6-588e-8e82a2b34a38@gentoo.org \
--to=zmedico@gentoo.org \
--cc=bman@gentoo.org \
--cc=gentoo-portage-dev@lists.gentoo.org \
--cc=sam@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox