From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 174371382C5 for ; Fri, 23 Mar 2018 01:09:57 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id A73ECE07EF; Fri, 23 Mar 2018 01:09:55 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 5C7E7E079C for ; Fri, 23 Mar 2018 01:09:55 +0000 (UTC) Received: from [10.128.13.172] (unknown [100.42.98.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: zmedico) by smtp.gentoo.org (Postfix) with ESMTPSA id D6951335C7E; Fri, 23 Mar 2018 01:09:52 +0000 (UTC) Subject: Re: [gentoo-portage-dev] [PATCH 0/3] INSTALL_MASK refurbishing resubmit To: gentoo-portage-dev@lists.gentoo.org, Joakim Tjernlund , "mgorny@gentoo.org" References: <20180315192212.13454-1-mgorny@gentoo.org> <69cb373e-9260-9f06-058d-ed269509484b@gentoo.org> <1521766349.4790.337.camel@infinera.com> From: Zac Medico Message-ID: <258569c2-eb72-8701-a6e2-c6372a450e04@gentoo.org> Date: Thu, 22 Mar 2018 18:09:50 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 In-Reply-To: <1521766349.4790.337.camel@infinera.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="cIYUlLUhvfjfwlv71sP0TgX0S9RCSO8ar" X-Archives-Salt: dfc6d940-131f-48a1-90cc-03721ad691c5 X-Archives-Hash: bde487777cbb359ebbeb7ebecdeef54d This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --cIYUlLUhvfjfwlv71sP0TgX0S9RCSO8ar Content-Type: multipart/mixed; boundary="zf53x1Z6x7XOv4Of8fpEQwZmiMa5QAwIK"; protected-headers="v1" From: Zac Medico To: gentoo-portage-dev@lists.gentoo.org, Joakim Tjernlund , "mgorny@gentoo.org" Message-ID: <258569c2-eb72-8701-a6e2-c6372a450e04@gentoo.org> Subject: Re: [gentoo-portage-dev] [PATCH 0/3] INSTALL_MASK refurbishing resubmit References: <20180315192212.13454-1-mgorny@gentoo.org> <69cb373e-9260-9f06-058d-ed269509484b@gentoo.org> <1521766349.4790.337.camel@infinera.com> In-Reply-To: <1521766349.4790.337.camel@infinera.com> --zf53x1Z6x7XOv4Of8fpEQwZmiMa5QAwIK Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 03/22/2018 05:52 PM, Joakim Tjernlund wrote: > On Mon, 2018-03-19 at 15:59 -0700, Zac Medico wrote: >> On 03/15/2018 12:22 PM, Micha=C5=82 G=C3=B3rny wrote: >>> Hi, >>> >>> Here are three of four INSTALL_MASK updates I've sent long time ago >>> which were not really reviewed. The fourth patch added support >>> for repo-defined install-mask.conf and I'll do that separately. >>> >>> Those patches focus on smaller changes. What they change, in order: >>> >>> 1. Removes explicit file removal code for FEATURES=3Dno*. Instead, th= ose >>> values are converted into additional INSTALL_MASK entries >>> and handled directly via INSTALL_MASK processing. >>> >>> 2. Rework INSTALL_MASK to filter files while installing instead of >>> pre-stripping them. In other words, before: INSTALL_MASK removes >>> files from ${D} before merge. After: ${D} contains all the files, >>> Portage just skip INSTALL_MASK-ed stuff, verbosely indicating that= =2E >>> >>> 3. Adds support for exclusions in INSTALL_MASK. In other words, you >>> can do stuff like: >>> >>> INSTALL_MASK=3D"/usr/share/locale -/usr/share/locale/en_US" >>> >>> I have been using this via user patches since the last submission. >>> Guessing by 'git log', this means almost 2 years now. >>> >>> -- >>> Best regards, >>> Micha=C5=82 G=C3=B3rny >>> >>> Micha=C5=82 G=C3=B3rny (3): >>> portage.package.ebuild.config: Move FEATURES=3Dno* handling there >>> portage.dbapi.vartree: Move INSTALL_MASK handling into merging >>> portage.dbapi.vartree: Support exclusions in INSTALL_MASK >>> >>> bin/misc-functions.sh | 30 ---------- >>> pym/portage/dbapi/vartree.py | 104 ++++++++++++++++++++++---= ---------- >>> pym/portage/package/ebuild/config.py | 11 ++++ >>> 3 files changed, 77 insertions(+), 68 deletions(-) >>> >> >> As mentioned in #gentoo-portage today, the rationale for including the= >> INSTALL_MASKed files in CONTENTS is to that we can detect collisions >> that would have occurred had people not been using INSTALL_MASK. >> >> Since people can use INSTALL_MASK to intentionally prevent collisions,= >> in cases where COLLISION_IGNORE is not appropriate (this is common >> practice at my workplace), we'll need a new FEATURES setting to trigge= r >> the new behavior where INSTALL_MASKed files still trigger file collisi= ons. >=20 > Are we going to see this in Portage soon? And PKG_INSTALL_MASK too ? Yes, I'll clean up the patches an resubmit them. Bug filed: https://bugs.gentoo.org/651214 --=20 Thanks, Zac --zf53x1Z6x7XOv4Of8fpEQwZmiMa5QAwIK-- --cIYUlLUhvfjfwlv71sP0TgX0S9RCSO8ar Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iHEEARECADEWIQSG5RNTeMgVEruefzL96O+FrlcZowUCWrRT3hMcem1lZGljb0Bn ZW50b28ub3JnAAoJEP3o74WuVxmjPb4AoIuReHVYNSDX1kvTOwdotnxMjEJrAJ94 Xj14oWZtpG6wBftZkm6lX0hDEQ== =Or70 -----END PGP SIGNATURE----- --cIYUlLUhvfjfwlv71sP0TgX0S9RCSO8ar--