[gentoo-portage-dev] [PATCH] Don't modify /etc/mtab from temporary namespaces

[gentoo-portage-dev] [PATCH] Don't modify /etc/mtab from temporary namespaces

[i.Dark_Templar]

These records are never removed and just pollute
/etc/mtab if that's a regular file.
And if /etc/mtab isn't a regular file,
then attempts to modify it are pointless.
---
 lib/portage/process.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/portage/process.py b/lib/portage/process.py
index 0dba55de3..dfbda75de 100644
--- a/lib/portage/process.py
+++ b/lib/portage/process.py
@@ -617,7 +617,7 @@ def _exec(binary, mycommand, opt_name, fd_pipes,
 								os._exit(1)
 							# mount new /proc for our namespace
 							s = subprocess.Popen(['mount',
-								'-t', 'proc', 'proc', '/proc'])
+								'-n', '-t', 'proc', 'proc', '/proc'])
 							mount_ret = s.wait()
 							if mount_ret != 0:
 								writemsg("Unable to mount new /proc: %d\n" % (mount_ret,),
-- 
2.21.0

Re: [gentoo-portage-dev] [PATCH] Don't modify /etc/mtab from temporary namespaces

[Zac Medico]

[-- Attachment #1.1: Type: text/plain, Size: 1035 bytes --]

On 5/27/19 1:23 PM, i.Dark_Templar wrote:
> These records are never removed and just pollute
> /etc/mtab if that's a regular file.
> And if /etc/mtab isn't a regular file,
> then attempts to modify it are pointless.
> ---
>  lib/portage/process.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/portage/process.py b/lib/portage/process.py
> index 0dba55de3..dfbda75de 100644
> --- a/lib/portage/process.py
> +++ b/lib/portage/process.py
> @@ -617,7 +617,7 @@ def _exec(binary, mycommand, opt_name, fd_pipes,
>  								os._exit(1)
>  							# mount new /proc for our namespace
>  							s = subprocess.Popen(['mount',
> -								'-t', 'proc', 'proc', '/proc'])
> +								'-n', '-t', 'proc', 'proc', '/proc'])
>  							mount_ret = s.wait()
>  							if mount_ret != 0:
>  								writemsg("Unable to mount new /proc: %d\n" % (mount_ret,),
> 

Thanks, merged:

https://gitweb.gentoo.org/proj/portage.git/commit/?id=ee2e8e8d65713760f85664bcb004e67aed8228d3
-- 
Thanks,
Zac


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 981 bytes --]