From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id ABF291384B4 for ; Wed, 18 Nov 2015 07:29:24 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 5818021C025; Wed, 18 Nov 2015 07:29:22 +0000 (UTC) Received: from a1www.kph.uni-mainz.de (a1www.kph.uni-mainz.de [134.93.134.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 9910421C024 for ; Wed, 18 Nov 2015 07:29:21 +0000 (UTC) Received: from a1i15.kph.uni-mainz.de (a1i15.kph.uni-mainz.de [134.93.134.92]) by a1www.kph.uni-mainz.de (8.14.9/8.14.7) with ESMTP id tAI7TGlV006924; Wed, 18 Nov 2015 08:29:16 +0100 Received: from a1i15.kph.uni-mainz.de (localhost [127.0.0.1]) by a1i15.kph.uni-mainz.de (8.14.8/8.14.2) with ESMTP id tAI7TGsL016995; Wed, 18 Nov 2015 08:29:16 +0100 Received: (from ulm@localhost) by a1i15.kph.uni-mainz.de (8.14.8/8.14.8/Submit) id tAI7TGop016991; Wed, 18 Nov 2015 08:29:16 +0100 Message-ID: <22092.10444.540147.390684@a1i15.kph.uni-mainz.de> Date: Wed, 18 Nov 2015 08:29:16 +0100 To: gentoo-portage-dev@lists.gentoo.org Cc: =?iso-8859-2?Q?Micha=B3_G=F3rny?= Subject: Re: [gentoo-portage-dev] [PATCH] EAPI 6: Fail if eapply_user is not called in src_prepare() In-Reply-To: <564C24C0.5040708@gentoo.org> References: <1447798842-5013-1-git-send-email-mgorny@gentoo.org> <22092.8754.979290.188470@a1i15.kph.uni-mainz.de> <564C24C0.5040708@gentoo.org> X-Mailer: VM 8.2.0b under 24.3.1 (x86_64-pc-linux-gnu) From: Ulrich Mueller Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; boundary="pgp+signed+ZdCP91EEPfFttJP"; micalg=pgp-sha256; protocol="application/pgp-signature" X-Archives-Salt: ba2de733-94a9-41b8-a229-b4022a5095b4 X-Archives-Hash: 7f20c02567f03c8449cd7ba4a0e60126 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --pgp+signed+ZdCP91EEPfFttJP Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit >>>>> On Tue, 17 Nov 2015, Zac Medico wrote: >> What happens if an ebuild calls eapply_user in src_unpack but not >> in src_prepare? > It will succeed in that case. It should die if it isn't called in src_prepare. > If necessary, we can make eapply_user die if it's called during the > wrong phase. That's not really mandated by the spec, but I think such extra strictness would be a good idea. Ulrich --pgp+signed+ZdCP91EEPfFttJP Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQEcBAEBCAAGBQJWTCjAAAoJEMMJBoUcYcJzKcAIAI/3IEazSgpm+aBBGSZ9xhqH ysbD/QJdRue73pgWH8g+zxyrtMdubxPkCeCuLu649Lq/SXeEF/87dwcVnivHq/hB Fp3cwm0ASLIXZ0XyP101Ya7T8chz/hDJ1+Oqqml6N7YW+zHZgH8F2JKGa8+xq11W JXR4h+1WF1O8F0txLaB2WtH3SJ/t/dEd3jhY1LOQRbXHrAtKKwxcSZaYguf68OQk dGgfzlrQM11n82VAnH4nTOyyHB4OvvcIVa3DHDjX0PDC4dXC8HFCWInjLHV50bl+ gQWAnw9NKthVD1DoBR1PcmZ/Rur5EojEklLR5SXjUckpRaisO5opCB2lJg7Zrjc= =65Yg -----END PGP SIGNATURE----- --pgp+signed+ZdCP91EEPfFttJP--