* [gentoo-portage-dev] [PATCH] _backtrack_depgraph: fix premature backtracking termination (bug 693242)
@ 2019-09-01 0:31 Zac Medico
0 siblings, 0 replies; only message in thread
From: Zac Medico @ 2019-09-01 0:31 UTC (permalink / raw
To: gentoo-portage-dev; +Cc: Zac Medico
Make backtracking continue as long as the backtracker has remaining
nodes to explore. This fixes a case where it would terminate prematurely
when the depgraph.need_restart() method returned False, even though the
backtracker had remaining nodes to explore.
Bug: https://bugs.gentoo.org/693242
Signed-off-by: Zac Medico <zmedico@gentoo.org>
---
lib/_emerge/depgraph.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/_emerge/depgraph.py b/lib/_emerge/depgraph.py
index 3e99ac077..08240af67 100644
--- a/lib/_emerge/depgraph.py
+++ b/lib/_emerge/depgraph.py
@@ -9794,8 +9794,8 @@ def _backtrack_depgraph(settings, trees, myopts, myparams, myaction, myfiles, sp
elif mydepgraph.need_restart():
backtracked += 1
backtracker.feedback(mydepgraph.get_backtrack_infos())
- else:
- break
+ elif backtracker:
+ backtracked += 1
if not (success or mydepgraph.need_config_change()) and backtracked:
--
2.21.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2019-09-01 0:33 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-09-01 0:31 [gentoo-portage-dev] [PATCH] _backtrack_depgraph: fix premature backtracking termination (bug 693242) Zac Medico
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox