[gentoo-portage-dev] [PATCH] [repoman] Allow empty LICENSE in acct-* packages

[gentoo-portage-dev] [PATCH] [repoman] Allow empty LICENSE in acct-* packages

[Michał Górny]

Since acct-* packages do not create any files (except for keepfile
for the home directory), it is perfectly normal for the LICENSE
to be empty.
---
 repoman/lib/repoman/modules/scan/metadata/ebuild_metadata.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/repoman/lib/repoman/modules/scan/metadata/ebuild_metadata.py b/repoman/lib/repoman/modules/scan/metadata/ebuild_metadata.py
index 4c35bbc12..2edf8f7f2 100644
--- a/repoman/lib/repoman/modules/scan/metadata/ebuild_metadata.py
+++ b/repoman/lib/repoman/modules/scan/metadata/ebuild_metadata.py
@@ -39,8 +39,8 @@ class EbuildMetadata(ScanBase):
 		ebuild = kwargs.get('ebuild').get()
 		for pos, missing_var in enumerate(self.repo_settings.qadata.missingvars):
 			if not ebuild.metadata.get(missing_var):
-				if kwargs.get('catdir') == "virtual" and \
-					missing_var in ("HOMEPAGE", "LICENSE"):
+				if (kwargs.get('catdir') in ("acct-group", "acct-user", "virtual")
+						and missing_var in ("HOMEPAGE", "LICENSE")):
 					continue
 				if ebuild.live_ebuild and missing_var == "KEYWORDS":
 					continue
-- 
2.22.0

Re: [gentoo-portage-dev] [PATCH] [repoman] Allow empty LICENSE in acct-* packages

[Zac Medico]

[-- Attachment #1.1: Type: text/plain, Size: 1342 bytes --]

On 6/20/19 5:33 AM, Michał Górny wrote:
> Since acct-* packages do not create any files (except for keepfile
> for the home directory), it is perfectly normal for the LICENSE
> to be empty.
> ---
>  repoman/lib/repoman/modules/scan/metadata/ebuild_metadata.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/repoman/lib/repoman/modules/scan/metadata/ebuild_metadata.py b/repoman/lib/repoman/modules/scan/metadata/ebuild_metadata.py
> index 4c35bbc12..2edf8f7f2 100644
> --- a/repoman/lib/repoman/modules/scan/metadata/ebuild_metadata.py
> +++ b/repoman/lib/repoman/modules/scan/metadata/ebuild_metadata.py
> @@ -39,8 +39,8 @@ class EbuildMetadata(ScanBase):
>  		ebuild = kwargs.get('ebuild').get()
>  		for pos, missing_var in enumerate(self.repo_settings.qadata.missingvars):
>  			if not ebuild.metadata.get(missing_var):
> -				if kwargs.get('catdir') == "virtual" and \
> -					missing_var in ("HOMEPAGE", "LICENSE"):
> +				if (kwargs.get('catdir') in ("acct-group", "acct-user", "virtual")
> +						and missing_var in ("HOMEPAGE", "LICENSE")):
>  					continue
>  				if ebuild.live_ebuild and missing_var == "KEYWORDS":
>  					continue
> 

Thanks, merged:

https://gitweb.gentoo.org/proj/portage.git/commit/?id=73232537c3f7d8cb4121c0a2dee5b450de584e38
-- 
Thanks,
Zac


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 981 bytes --]