* [gentoo-portage-dev] [PATCH] XARGS: use gxargs for USERLAND=BSD (bug 663256)
@ 2018-08-09 23:04 Zac Medico
2018-08-09 23:17 ` M. J. Everitt
2018-08-09 23:56 ` Brian Dolbec
0 siblings, 2 replies; 4+ messages in thread
From: Zac Medico @ 2018-08-09 23:04 UTC (permalink / raw
To: gentoo-portage-dev; +Cc: Zac Medico
For USERLAND=BSD, set XARGS="gxargs -r" if gxargs is available,
so the code from bug 630292 works for USERLAND=BSD.
Fixes: 50283f1abb77 (install-qa-check.d/60pngfix: parallel support (bug 630292))
Reported-by: Michał Górny <mgorny@gentoo.org>
Bug: https://bugs.gentoo.org/663256
---
bin/isolated-functions.sh | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/bin/isolated-functions.sh b/bin/isolated-functions.sh
index 28ca94532..cac42a4c5 100644
--- a/bin/isolated-functions.sh
+++ b/bin/isolated-functions.sh
@@ -448,7 +448,11 @@ fi
if [[ -z ${XARGS} ]] ; then
case ${USERLAND} in
BSD)
- export XARGS="xargs"
+ if type -P gxargs > /dev/null; then
+ export XARGS="gxargs -r"
+ else
+ export XARGS="xargs"
+ fi
;;
*)
export XARGS="xargs -r"
--
2.16.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [gentoo-portage-dev] [PATCH] XARGS: use gxargs for USERLAND=BSD (bug 663256)
2018-08-09 23:04 [gentoo-portage-dev] [PATCH] XARGS: use gxargs for USERLAND=BSD (bug 663256) Zac Medico
@ 2018-08-09 23:17 ` M. J. Everitt
2018-08-09 23:18 ` M. J. Everitt
2018-08-09 23:56 ` Brian Dolbec
1 sibling, 1 reply; 4+ messages in thread
From: M. J. Everitt @ 2018-08-09 23:17 UTC (permalink / raw
To: gentoo-portage-dev, Zac Medico
[-- Attachment #1.1: Type: text/plain, Size: 948 bytes --]
On 10/08/18 00:04, Zac Medico wrote:
> For USERLAND=BSD, set XARGS="gxargs -r" if gxargs is available,
> so the code from bug 630292 works for USERLAND=BSD.
>
> Fixes: 50283f1abb77 (install-qa-check.d/60pngfix: parallel support (bug 630292))
> Reported-by: Michał Górny <mgorny@gentoo.org>
> Bug: https://bugs.gentoo.org/663256
> ---
> bin/isolated-functions.sh | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/bin/isolated-functions.sh b/bin/isolated-functions.sh
> index 28ca94532..cac42a4c5 100644
> --- a/bin/isolated-functions.sh
> +++ b/bin/isolated-functions.sh
> @@ -448,7 +448,11 @@ fi
> if [[ -z ${XARGS} ]] ; then
> case ${USERLAND} in
> BSD)
> - export XARGS="xargs"
> + if type -P gxargs > /dev/null; then
> + export XARGS="gxargs -r"
> + else
> + export XARGS="xargs"
> + fi
> ;;
> *)
> export XARGS="xargs -r"
Isn't the else clause there redundant?
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [gentoo-portage-dev] [PATCH] XARGS: use gxargs for USERLAND=BSD (bug 663256)
2018-08-09 23:17 ` M. J. Everitt
@ 2018-08-09 23:18 ` M. J. Everitt
0 siblings, 0 replies; 4+ messages in thread
From: M. J. Everitt @ 2018-08-09 23:18 UTC (permalink / raw
To: gentoo-portage-dev, Zac Medico
[-- Attachment #1.1: Type: text/plain, Size: 1099 bytes --]
On 10/08/18 00:17, M. J. Everitt wrote:
> On 10/08/18 00:04, Zac Medico wrote:
>> For USERLAND=BSD, set XARGS="gxargs -r" if gxargs is available,
>> so the code from bug 630292 works for USERLAND=BSD.
>>
>> Fixes: 50283f1abb77 (install-qa-check.d/60pngfix: parallel support (bug 630292))
>> Reported-by: Michał Górny <mgorny@gentoo.org>
>> Bug: https://bugs.gentoo.org/663256
>> ---
>> bin/isolated-functions.sh | 6 +++++-
>> 1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/bin/isolated-functions.sh b/bin/isolated-functions.sh
>> index 28ca94532..cac42a4c5 100644
>> --- a/bin/isolated-functions.sh
>> +++ b/bin/isolated-functions.sh
>> @@ -448,7 +448,11 @@ fi
>> if [[ -z ${XARGS} ]] ; then
>> case ${USERLAND} in
>> BSD)
>> - export XARGS="xargs"
>> + if type -P gxargs > /dev/null; then
>> + export XARGS="gxargs -r"
>> + else
>> + export XARGS="xargs"
>> + fi
>> ;;
>> *)
>> export XARGS="xargs -r"
> Isn't the else clause there redundant?
>
Oops, sorry missed the minus before the first export .. my bad .. </noise>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [gentoo-portage-dev] [PATCH] XARGS: use gxargs for USERLAND=BSD (bug 663256)
2018-08-09 23:04 [gentoo-portage-dev] [PATCH] XARGS: use gxargs for USERLAND=BSD (bug 663256) Zac Medico
2018-08-09 23:17 ` M. J. Everitt
@ 2018-08-09 23:56 ` Brian Dolbec
1 sibling, 0 replies; 4+ messages in thread
From: Brian Dolbec @ 2018-08-09 23:56 UTC (permalink / raw
To: gentoo-portage-dev
On Thu, 9 Aug 2018 16:04:42 -0700
Zac Medico <zmedico@gentoo.org> wrote:
> For USERLAND=BSD, set XARGS="gxargs -r" if gxargs is available,
> so the code from bug 630292 works for USERLAND=BSD.
>
> Fixes: 50283f1abb77 (install-qa-check.d/60pngfix: parallel support
> (bug 630292)) Reported-by: Michał Górny <mgorny@gentoo.org>
> Bug: https://bugs.gentoo.org/663256
> ---
> bin/isolated-functions.sh | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/bin/isolated-functions.sh b/bin/isolated-functions.sh
> index 28ca94532..cac42a4c5 100644
> --- a/bin/isolated-functions.sh
> +++ b/bin/isolated-functions.sh
> @@ -448,7 +448,11 @@ fi
> if [[ -z ${XARGS} ]] ; then
> case ${USERLAND} in
> BSD)
> - export XARGS="xargs"
> + if type -P gxargs > /dev/null; then
> + export XARGS="gxargs -r"
> + else
> + export XARGS="xargs"
> + fi
> ;;
> *)
> export XARGS="xargs -r"
LGTM
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-08-09 23:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-09 23:04 [gentoo-portage-dev] [PATCH] XARGS: use gxargs for USERLAND=BSD (bug 663256) Zac Medico
2018-08-09 23:17 ` M. J. Everitt
2018-08-09 23:18 ` M. J. Everitt
2018-08-09 23:56 ` Brian Dolbec
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox