From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id B6BFE1382C5 for ; Thu, 8 Feb 2018 18:27:40 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 841DEE0AD4; Thu, 8 Feb 2018 18:27:39 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 53483E0AD3 for ; Thu, 8 Feb 2018 18:27:39 +0000 (UTC) Received: from professor-x (d172-218-130-5.bchsia.telus.net [172.218.130.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: dolsen) by smtp.gentoo.org (Postfix) with ESMTPSA id 48544335C30 for ; Thu, 8 Feb 2018 18:27:38 +0000 (UTC) Date: Thu, 8 Feb 2018 10:27:16 -0800 From: Brian Dolbec To: gentoo-portage-dev@lists.gentoo.org Subject: Re: [gentoo-portage-dev] [PATCH] emerge: disable --changed-deps-report by default (bug 645780) Message-ID: <20180208102716.4ff16a6f@professor-x> In-Reply-To: <20180203025235.6141-1-zmedico@gentoo.org> References: <20180203025235.6141-1-zmedico@gentoo.org> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Archives-Salt: 8f9e9295-a1ed-4a8f-96ad-6092c0a9f519 X-Archives-Hash: 70718902515b813b7d63c62b64d194b2 On Fri, 2 Feb 2018 18:52:35 -0800 Zac Medico wrote: > This option is too noisy to enable by default, since it reports > hundreds of packages for most users. >=20 > Suggested-by: Micha=C5=82 G=C3=B3rny > Bug: https://bugs.gentoo.org/645780 > --- > man/emerge.1 | 7 +------ > pym/_emerge/create_depgraph_params.py | 6 ++---- > 2 files changed, 3 insertions(+), 10 deletions(-) >=20 > diff --git a/man/emerge.1 b/man/emerge.1 > index 189e6f879..810336fa4 100644 > --- a/man/emerge.1 > +++ b/man/emerge.1 > @@ -469,12 +469,7 @@ respect to changed build\-time dependencies is > controlled by the Tells emerge to report ebuilds for which the ebuild > dependencies have changed since the installed instance was built. > Behavior with respect to changed build\-time dependencies is > controlled by the -\fB\-\-with\-bdeps\fR option. If the > \fB\-\-update\fR and \fB\-\-deep\fR -options are enabled then this > option is enabled automatically for a -dependency calculation if the > cost of report generation is relatively -insignificant (any > calculation exclusively involving binary packages is -exempt). The > \fIEMERGE_DEFAULT_OPTS\fR variable may be used to disable -this by > default. +\fB\-\-with\-bdeps\fR option. > .TP > .BR \-\-changed\-use ", " \-U > Tells emerge to include installed packages where USE flags have > diff --git a/pym/_emerge/create_depgraph_params.py > b/pym/_emerge/create_depgraph_params.py index ecd65335c..6964bc65b > 100644 --- a/pym/_emerge/create_depgraph_params.py > +++ b/pym/_emerge/create_depgraph_params.py > @@ -127,10 +127,8 @@ def create_depgraph_params(myopts, myaction): > if changed_deps is not None: > myparams['changed_deps'] =3D changed_deps > =20 > - changed_deps_report =3D myopts.get('--changed-deps-report') > - if (changed_deps_report !=3D 'n' and > - not (myaction =3D=3D 'remove' or '--usepkgonly' in > myopts) and > - deep is True and '--update' in myopts): > + changed_deps_report =3D myopts.get('--changed-deps-report', > 'n') =3D=3D 'y' > + if changed_deps_report: > myparams['changed_deps_report'] =3D True > =20 > if myopts.get("--selective") =3D=3D "n": looks good, if not already merged. --=20 Brian Dolbec