From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 901751382C5 for ; Sat, 3 Feb 2018 02:53:17 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 4AEA6E09B7; Sat, 3 Feb 2018 02:53:16 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 13994E09B1 for ; Sat, 3 Feb 2018 02:53:15 +0000 (UTC) Received: from r6.ad.gaikai.biz (unknown [100.42.98.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: zmedico) by smtp.gentoo.org (Postfix) with ESMTPSA id 0ADEE335C53; Sat, 3 Feb 2018 02:53:14 +0000 (UTC) From: Zac Medico To: gentoo-portage-dev@lists.gentoo.org Cc: Zac Medico Subject: [gentoo-portage-dev] [PATCH] emerge: disable --changed-deps-report by default (bug 645780) Date: Fri, 2 Feb 2018 18:52:35 -0800 Message-Id: <20180203025235.6141-1-zmedico@gentoo.org> X-Mailer: git-send-email 2.13.6 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Archives-Salt: ae4ea7b8-88b9-420a-9f58-10941bc129cf X-Archives-Hash: 88b85783f11fa271835b1449d953804c This option is too noisy to enable by default, since it reports hundreds of packages for most users. Suggested-by: Michał Górny Bug: https://bugs.gentoo.org/645780 --- man/emerge.1 | 7 +------ pym/_emerge/create_depgraph_params.py | 6 ++---- 2 files changed, 3 insertions(+), 10 deletions(-) diff --git a/man/emerge.1 b/man/emerge.1 index 189e6f879..810336fa4 100644 --- a/man/emerge.1 +++ b/man/emerge.1 @@ -469,12 +469,7 @@ respect to changed build\-time dependencies is controlled by the Tells emerge to report ebuilds for which the ebuild dependencies have changed since the installed instance was built. Behavior with respect to changed build\-time dependencies is controlled by the -\fB\-\-with\-bdeps\fR option. If the \fB\-\-update\fR and \fB\-\-deep\fR -options are enabled then this option is enabled automatically for a -dependency calculation if the cost of report generation is relatively -insignificant (any calculation exclusively involving binary packages is -exempt). The \fIEMERGE_DEFAULT_OPTS\fR variable may be used to disable -this by default. +\fB\-\-with\-bdeps\fR option. .TP .BR \-\-changed\-use ", " \-U Tells emerge to include installed packages where USE flags have diff --git a/pym/_emerge/create_depgraph_params.py b/pym/_emerge/create_depgraph_params.py index ecd65335c..6964bc65b 100644 --- a/pym/_emerge/create_depgraph_params.py +++ b/pym/_emerge/create_depgraph_params.py @@ -127,10 +127,8 @@ def create_depgraph_params(myopts, myaction): if changed_deps is not None: myparams['changed_deps'] = changed_deps - changed_deps_report = myopts.get('--changed-deps-report') - if (changed_deps_report != 'n' and - not (myaction == 'remove' or '--usepkgonly' in myopts) and - deep is True and '--update' in myopts): + changed_deps_report = myopts.get('--changed-deps-report', 'n') == 'y' + if changed_deps_report: myparams['changed_deps_report'] = True if myopts.get("--selective") == "n": -- 2.13.6