From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 6EC95138806 for ; Tue, 5 Dec 2017 16:59:36 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 24F12E0FB4; Tue, 5 Dec 2017 16:59:35 +0000 (UTC) Received: from smtp.gentoo.org (mail.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id E0E56E0ED0 for ; Tue, 5 Dec 2017 16:59:34 +0000 (UTC) Received: from professor-x (d172-218-130-5.bchsia.telus.net [172.218.130.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: dolsen) by smtp.gentoo.org (Postfix) with ESMTPSA id D70D533BE2E for ; Tue, 5 Dec 2017 16:59:33 +0000 (UTC) Date: Tue, 5 Dec 2017 08:59:30 -0800 From: Brian Dolbec To: gentoo-portage-dev@lists.gentoo.org Subject: Re: [gentoo-portage-dev] [PATCH] [checksum] Disable pygcrypt backend due to breakage Message-ID: <20171205085930.6cca8fd3@professor-x> In-Reply-To: <20171205084243.02805442@professor-x> References: <20171205163423.4379-1-mgorny@gentoo.org> <20171205084243.02805442@professor-x> X-Mailer: Claws Mail 3.15.1-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Archives-Salt: 38e8a4a7-0f1c-4c4b-abbd-879bdf5240fa X-Archives-Hash: ecac966736a7f661ecc517b776712378 On Tue, 5 Dec 2017 08:42:43 -0800 Brian Dolbec wrote: > On Tue, 5 Dec 2017 17:34:23 +0100 > Micha=C5=82 G=C3=B3rny wrote: >=20 > > Closes: https://bugs.gentoo.org/615620 > > --- > > pym/portage/checksum.py | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > >=20 > > diff --git a/pym/portage/checksum.py b/pym/portage/checksum.py > > index 5424ce56b..0841ab231 100644 > > --- a/pym/portage/checksum.py > > +++ b/pym/portage/checksum.py > > @@ -150,7 +150,10 @@ if "SHA3_256" not in hashfunc_map or "SHA3_512" > > not in hashfunc_map: # (GnuPG). > > gcrypt_algos =3D frozenset(('RMD160', 'WHIRLPOOL', 'SHA3_256', > > 'SHA3_512', 'STREEBOG256', 'STREEBOG512')) > > -if gcrypt_algos.difference(hashfunc_map): > > +# Note: currently disabled due to resource exhaustion bugs in > > pygcrypt. +# Please do not reenable until upstream has a fix. > > +# https://bugs.gentoo.org/615620 > > +if False and gcrypt_algos.difference(hashfunc_map): > > try: > > import binascii > > import pygcrypt.hashcontext =20 >=20 >=20 >=20 > It would be better to just comment out the original if, then add a new > line to replace it with just if False. it would be clearer what the > original code should be. Of course with the reason comments... >=20 sorry, brain is still struggling with this damn headache... It would be clearer later when re-enabling if it takes a long time=20 for pygrcrypt to get fixed. I know it would be for me, my memory=20 isn't as good as it used to be. Also if it ends up someone else=20 looks to modify it later. +# Note: currently disabled due to resource exhaustion bugs in pygcrypt.=20 +# Please do not reenable until upstream has a fix.=20 +# https://bugs.gentoo.org/615620=20 -if gcrypt_algos.difference(hashfunc_map): +#if gcrypt_algos.difference(hashfunc_map): +if False try: import binascii import pygcrypt.hashcontext =20 I approve the above form to merge... Thanks --=20 Brian Dolbec