From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 180ED1396D0 for ; Wed, 30 Aug 2017 09:07:01 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 030851FC018; Wed, 30 Aug 2017 09:07:00 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id CABD41FC015 for ; Wed, 30 Aug 2017 09:06:59 +0000 (UTC) Received: from localhost.localdomain (d202-252.icpnet.pl [109.173.202.252]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mgorny) by smtp.gentoo.org (Postfix) with ESMTPSA id E6FF133D3C7; Wed, 30 Aug 2017 09:06:57 +0000 (UTC) From: =?UTF-8?q?Micha=C5=82=20G=C3=B3rny?= To: gentoo-portage-dev@lists.gentoo.org Cc: =?UTF-8?q?Micha=C5=82=20G=C3=B3rny?= Subject: [gentoo-portage-dev] [PATCH] ebuild.sh: Explicitly ban get_libdir in global scope Date: Wed, 30 Aug 2017 11:06:52 +0200 Message-Id: <20170830090652.21718-1-mgorny@gentoo.org> X-Mailer: git-send-email 2.14.1 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org X-Archives-Salt: 3344b92b-9613-4451-9124-c4a1cf03c17e X-Archives-Hash: 6ffd4c77dd8b07ec1d2aae40dde05875 The value of get_libdir depends on the profile, and so it is not useful for dependency calculations. Furthermore, it seems that Portage does not handle defining it in global scope well due to EAPI checking magic. Ban it completely where it is defined as EAPI function to let developers catch their mistakes early rather than see them as 'command not found' errors during dependency calculation / cache updates. Bug: https://bugs.gentoo.org/629010 --- bin/ebuild.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/bin/ebuild.sh b/bin/ebuild.sh index a400ef72e..f1ac3f278 100755 --- a/bin/ebuild.sh +++ b/bin/ebuild.sh @@ -66,6 +66,7 @@ else use useq usev use_with use_enable" ___eapi_has_usex && funcs+=" usex" ___eapi_has_in_iuse && funcs+=" in_iuse" + ___eapi_has_get_libdir && funcs+=" get_libdir" # These functions die because calls to them during the "depend" phase # are considered to be severe QA violations. funcs+=" best_version has_version portageq" -- 2.14.1