From: Kerin Millar <kfm@plushkava.net>
To: gentoo-portage-dev@lists.gentoo.org
Cc: Zac Medico <zmedico@gentoo.org>
Subject: Re: [gentoo-portage-dev] [PATCH v2] AbstractEbuildProcess: disable ipc_daemon under Windows Subsystem for Linux
Date: Mon, 26 Sep 2016 23:58:15 +0100 [thread overview]
Message-ID: <20160926235815.4d835f1c8c9da95e85f7a702@plushkava.net> (raw)
In-Reply-To: <CAMiTYSogp5aoc74G_7UY2Poj38e-wDB5Ng+Ne24aN515DYKR+w@mail.gmail.com>
On Sun, 25 Sep 2016 22:49:59 -0700
Zac Medico <zmedico@gentoo.org> wrote:
> On Thu, Sep 22, 2016 at 8:48 PM, Zac Medico <zmedico@gentoo.org> wrote:
> > On Thu, Sep 22, 2016 at 8:23 PM, Kerin Millar <kfm@plushkava.net> wrote:
> >> Duly updated to use any instead of ==, as recommended by Brian Dolbec.
> >>
> >> --
> >> Kerin Millar <kfm@plushkava.net>
> >
> > My first choice would be to use a small test case to detect when ipc
> > is broken, and disable it dynamically. A good example of such a test
> > is the can_poll_device function here:
> >
> > https://gitweb.gentoo.org/proj/portage.git/tree/pym/portage/util/_eventloop/EventLoop.py?h=portage-2.3.1#n597
> >
> > If it's not possible to use a test similar to the above, maybe it's
> > best to use /proc/version or /proc/sys/kernel/osrelease as mentioned
> > in the following issue:
> >
> > https://github.com/Microsoft/BashOnWindows/issues/423
> >
> > Thanks,
> > Zac
>
> I've started playing around with WSL, and I've discovered that
> portage's ipc actually works if we use fcntl.flock instead of
> fcntl.lockf!!! Simply set _default_lock_fn = fcntl.flock in
> pym/portage/locks.py, and watch the tests succeed:
>
> $ pym/portage/tests/runTests.py pym/portage/tests/ebuild/test_ipc_daemon.py
> testIpcDaemon (portage.tests.ebuild.test_ipc_daemon.IpcDaemonTestCase) ... ok
>
> ----------------------------------------------------------------------
> Ran 1 test in 1.282s
>
> OK
How strange!
> So, I'm thinking that we should add a dynamic test inside
> pym/portage/locks.py which checks for a broken fcntl.lockf, and falls
> back to fcntl.flock in that case.
Sounds good to me. Thank you for looking into it.
--
Kerin Millar <kfm@plushkava.net>
next prev parent reply other threads:[~2016-09-26 22:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-26 5:49 [gentoo-portage-dev] [PATCH v2] AbstractEbuildProcess: disable ipc_daemon under Windows Subsystem for Linux Zac Medico
2016-09-26 22:58 ` Kerin Millar [this message]
2016-09-27 16:26 ` Zac Medico
-- strict thread matches above, loose matches on Subject: below --
2016-09-23 3:48 Zac Medico
2016-09-26 22:55 ` Kerin Millar
2016-09-23 3:23 Kerin Millar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160926235815.4d835f1c8c9da95e85f7a702@plushkava.net \
--to=kfm@plushkava.net \
--cc=gentoo-portage-dev@lists.gentoo.org \
--cc=zmedico@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox