From: "Michał Górny" <mgorny@gentoo.org>
To: Zac Medico <zmedico@gentoo.org>
Cc: gentoo-portage-dev@lists.gentoo.org
Subject: Re: [gentoo-portage-dev] [PATCH 2/2] portage.util.configparser: Commonize portable config file reading routine
Date: Tue, 24 May 2016 08:28:55 +0200 [thread overview]
Message-ID: <20160524082855.5f522521.mgorny@gentoo.org> (raw)
In-Reply-To: <5741F4C3.5080803@gentoo.org>
[-- Attachment #1: Type: text/plain, Size: 880 bytes --]
On Sun, 22 May 2016 11:04:51 -0700
Zac Medico <zmedico@gentoo.org> wrote:
> On 05/22/2016 01:41 AM, Michał Górny wrote:
> > ---
> > pym/portage/_sets/__init__.py | 29 ++-----------------
> > pym/portage/repository/config.py | 38 ++-----------------------
> > pym/portage/util/_desktop_entry.py | 20 ++-----------
> > pym/portage/util/configparser.py | 57 +++++++++++++++++++++++++++++++++++++-
> > 4 files changed, 64 insertions(+), 80 deletions(-)
>
> These patches look good. Note that the _native_kwargs function is not
> really needed anymore, because it was just a workaround for this issue
> which only affected python 2.6.4 and earlier:
>
> http://bugs.python.org/issue4978
Pushed now, thanks.
I'll do a global _native_kwargs cleanup in a separate patch.
--
Best regards,
Michał Górny
<http://dev.gentoo.org/~mgorny/>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 949 bytes --]
prev parent reply other threads:[~2016-05-24 6:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-22 8:41 [gentoo-portage-dev] [PATCH 1/2] portage.util.configparser: Provide common code to handle cp imports Michał Górny
2016-05-22 8:41 ` [gentoo-portage-dev] [PATCH 2/2] portage.util.configparser: Commonize portable config file reading routine Michał Górny
2016-05-22 18:04 ` Zac Medico
2016-05-24 6:28 ` Michał Górny [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160524082855.5f522521.mgorny@gentoo.org \
--to=mgorny@gentoo.org \
--cc=gentoo-portage-dev@lists.gentoo.org \
--cc=zmedico@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox