From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id E20DB59CA3 for ; Tue, 15 Mar 2016 19:05:58 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 1DED121C01C; Tue, 15 Mar 2016 19:05:56 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 8688C21C017 for ; Tue, 15 Mar 2016 19:05:55 +0000 (UTC) Received: from professor-x (S010634bdfa9ecf80.vc.shawcable.net [96.49.31.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: dolsen) by smtp.gentoo.org (Postfix) with ESMTPSA id 6434A340C96 for ; Tue, 15 Mar 2016 19:05:53 +0000 (UTC) Date: Tue, 15 Mar 2016 12:04:57 -0700 From: Brian Dolbec To: gentoo-portage-dev@lists.gentoo.org Subject: Re: [gentoo-portage-dev] [Patch] Repoman rewrite stage2 modularization conversion complete Message-ID: <20160315120457.631e1dd3.dolsen@gentoo.org> In-Reply-To: <56E75FB8.9060802@gentoo.org> References: <20160110134008.4fce78c0.dolsen@gentoo.org> <5693CCAF.7020102@gentoo.org> <20160305133705.42b54258.dolsen@gentoo.org> <56E6F167.4050806@gentoo.org> <56E6F343.80005@gentoo.org> <20160314105256.37fb8e90.dolsen@gentoo.org> <56E754D3.5080308@gentoo.org> <20160314174710.4b6ebd1e.dolsen@gentoo.org> <56E75FB8.9060802@gentoo.org> Organization: Gentoo Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Archives-Salt: 6b187c94-5d53-492f-a921-82e5429cf31c X-Archives-Hash: 72cf0c2b47a2a4e56683c5a49bb2dbe3 On Mon, 14 Mar 2016 18:04:56 -0700 Zac Medico wrote: > > The only consumer for that allvalid variable is the metadata > > UnusedCheck class. > > > > So the allvalid variable is True until found False > > by whichever checks along the way find it to be False. Like a fuse, > > it's good until it's blown, then it can never be good again. I > > don't think this particular variable justifies a special class that > > more fully mimics a fuse. Impossible to reset it like a breaker. > > Yeah, let's do it. It's a great opportunity to add clarity to the > code, and prevent future goofs. > Done, it is now dynamic_data['validity_fuse'] which is a Fuse instance. P.S. I tried, but I could only rebase one of your 2 patches to the current repoman code. I could not apply the unboundlocal error patch. It looks like it is not valid for the cvs and svn modules now that they are separate modules. -- Brian Dolbec