[gentoo-portage-dev] [PATCH] doebuild: abort for missing DIST digests

[gentoo-portage-dev] [PATCH] doebuild: abort for missing DIST digests

[Zac Medico]

Fix the ebuild(1) command to abort when DIST digests are missing,
so behavior is consistent with emerge. Do not abort when generating
a manifest (including when "digest" is in FEATURES), or when the
ebuild --skip-manifest option is used (these cases are handled
outside of the doebuild function).
---
 pym/portage/package/ebuild/doebuild.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pym/portage/package/ebuild/doebuild.py b/pym/portage/package/ebuild/doebuild.py
index a4d4d9f..d926e03 100644
--- a/pym/portage/package/ebuild/doebuild.py
+++ b/pym/portage/package/ebuild/doebuild.py
@@ -1033,7 +1033,7 @@ def doebuild(myebuild, mydo, _unused=DeprecationWarning, settings=None, debug=0,
 			if mf is not None:
 				dist_digests = mf.getTypeDigests("DIST")
 			if not fetch(fetchme, mysettings, listonly=listonly,
-				fetchonly=fetchonly, allow_missing_digests=True,
+				fetchonly=fetchonly, allow_missing_digests=False,
 				digests=dist_digests):
 				spawn_nofetch(mydbapi, myebuild, settings=mysettings,
 					fd_pipes=fd_pipes)
-- 
2.4.10

Re: [gentoo-portage-dev] [PATCH] doebuild: abort for missing DIST digests

[Brian Dolbec]

On Tue, 23 Feb 2016 09:42:51 -0800
Zac Medico <zmedico@gentoo.org> wrote:

> Fix the ebuild(1) command to abort when DIST digests are missing,
> so behavior is consistent with emerge. Do not abort when generating
> a manifest (including when "digest" is in FEATURES), or when the
> ebuild --skip-manifest option is used (these cases are handled
> outside of the doebuild function).
> ---
>  pym/portage/package/ebuild/doebuild.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/pym/portage/package/ebuild/doebuild.py
> b/pym/portage/package/ebuild/doebuild.py index a4d4d9f..d926e03 100644
> --- a/pym/portage/package/ebuild/doebuild.py
> +++ b/pym/portage/package/ebuild/doebuild.py
> @@ -1033,7 +1033,7 @@ def doebuild(myebuild, mydo,
> _unused=DeprecationWarning, settings=None, debug=0, if mf is not None:
>  				dist_digests =
> mf.getTypeDigests("DIST") if not fetch(fetchme, mysettings,
> listonly=listonly,
> -				fetchonly=fetchonly,
> allow_missing_digests=True,
> +				fetchonly=fetchonly,
> allow_missing_digests=False, digests=dist_digests):
>  				spawn_nofetch(mydbapi, myebuild,
> settings=mysettings, fd_pipes=fd_pipes)


Makes sense to be consistent to me :)

-- 
Brian Dolbec <dolsen>