From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 2D3A41388BF for ; Mon, 11 Jan 2016 09:09:27 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 9860721C01C; Mon, 11 Jan 2016 09:09:26 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id B446F21C018 for ; Mon, 11 Jan 2016 09:09:25 +0000 (UTC) Received: from professor-x (S010634bdfa9ecf80.vc.shawcable.net [96.49.31.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: dolsen) by smtp.gentoo.org (Postfix) with ESMTPSA id A516A34072E for ; Mon, 11 Jan 2016 09:09:24 +0000 (UTC) Date: Mon, 11 Jan 2016 01:08:33 -0800 From: Brian Dolbec To: gentoo-portage-dev@lists.gentoo.org Subject: Re: [gentoo-portage-dev] [Patch] Repoman rewrite stage2 modularization conversion complete Message-ID: <20160111010833.398cfad3.dolsen@gentoo.org> In-Reply-To: <20160110142851.56e5e80c.dolsen@gentoo.org> References: <20160110134008.4fce78c0.dolsen@gentoo.org> <20160110142851.56e5e80c.dolsen@gentoo.org> Organization: Gentoo Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Archives-Salt: f04fcd92-2181-4f73-8c30-cc670944809f X-Archives-Hash: 15b7c765b0052dad401affed72a4c371 On Sun, 10 Jan 2016 14:28:51 -0800 Brian Dolbec wrote: > On Sun, 10 Jan 2016 13:40:08 -0800 > Brian Dolbec wrote: > > > I have now pushed a fully rebased, properly sequenced commit > > history to the repoman branch. To be honest I think all the > > rebasing, re-testing took as much time as the initial conversion > > and testing. Anyway, I consider the branch now ready for final > > review. Since there are a total of 45 commits. I am not sending > > them to the list at this time. They are available for review via > > the repoman branch at > > > > https://gitweb.gentoo.org/proj/portage.git/log/?h=repoman > > > > https://github.com/gentoo/portage/commits/repoman > > > > or github pull request for commit order convienience > > > > https://github.com/gentoo/portage/pull/22 > > > > But please try to follow our standard rules and reply with any > > comments or code review to this email thread. > > OK, There are 2 test failures I need to fix. The patch to the plugin > system seems to have broken emaint. Also there is one repoman test > failure which is I think related to the metadata.dtd url change. > Turned out to be more than just the None type vcs related failures. It also is failing due to me modifying the metadata.dtd url in repoman metadata.py updating it to the https://... url. But here is the strange part. I've traced the trouble to the resolverpalyground metadata.xml template still having it set to http://... BUT, it only correctly fails in python2.7 and pypy. Py3* it incorrectly passes tests. Both locally and Travis CI So, I believe that something must be broken if the tests pass in py3, but not py2/pypy for that type of static data. Since the data does not change, it should fail equally in all tested python versions. Zac, Arfrever, any ideas why? OK, after editing the template in tests/resolver/resolverplayground.py, I'm getting all passes locally. Not that it means much at this point. Summary: | Version | Status |-------------------- | 2.7 | PASS | 3.3 | PASS | 3.4 | PASS | pypy | PASS brian@professor-x ~/Dev/git/portage $ Here is the debug=True repoman/test_simple.py output: brian@professor-x ~/Dev/git/portage/pym/portage/tests $ python2.7 ./runTests.py repoman/test_simple.py testCopyrightUpdate (portage.tests.repoman.test_simple.SimpleRepomanTestCase) ... ok testSimple (portage.tests.repoman.test_simple.SimpleRepomanTestCase) ... >>> Creating Manifest for /tmp/tmpwfodHK/var/repositories/test_repo/dev-libs/A >>> Creating Manifest >>> for /tmp/tmpwfodHK/var/repositories/test_repo/dev-libs/A Creating >>> Manifest for /tmp/tmpwfodHK/var/repositories/test_repo/dev-libs/B >>> Creating Manifest >>> for /tmp/tmpwfodHK/var/repositories/test_repo/dev-libs/C RepoMan scours the neighborhood... ebuild.badheader 4 dev-libs/A/A-0.ebuild: Malformed Id header on line: 3 dev-libs/A/A-1.ebuild: Malformed Id header on line: 3 dev-libs/B/B-1.ebuild: Malformed Id header on line: 3 dev-libs/C/C-0.ebuild: Malformed Id header on line: 3 metadata.bad [fatal] 3 dev-libs/A/metadata.xml: DOCTYPE: SYSTEM should refer to 'https://www.gentoo.org/dtd/metadata.dtd', not 'http://www.gentoo.org/dtd/metadata.dtd' dev-libs/B/metadata.xml: DOCTYPE: SYSTEM should refer to 'https://www.gentoo.org/dtd/metadata.dtd', not 'http://www.gentoo.org/dtd/metadata.dtd' dev-libs/C/metadata.xml: DOCTYPE: SYSTEM should refer to 'https://www.gentoo.org/dtd/metadata.dtd', not 'http://www.gentoo.org/dtd/metadata.dtd' Note: use --include-dev (-d) to check dependencies for 'dev' profiles Please fix these important QA issues first. RepoMan sez: "Make your QA payment on time and you'll never see the likes of me." EROOT=/tmp/tmpwfodHK/ FAIL ====================================================================== FAIL: testSimple (portage.tests.repoman.test_simple.SimpleRepomanTestCase) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/brian/Dev/git/portage/pym/portage/tests/__init__.py", line 222, in run testMethod() File "/home/brian/Dev/git/portage/pym/portage/tests/repoman/test_simple.py", line 307, in testSimple "repoman failed in %s" % (cwd,)) AssertionError: repoman failed in ---------------------------------------------------------------------- Ran 2 tests in 0.621s FAILED (failures=1) -- Brian Dolbec