From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id BE20E1388BF for ; Mon, 11 Jan 2016 06:53:41 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 585D0E0857; Mon, 11 Jan 2016 06:53:40 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id D1E8CE0856 for ; Mon, 11 Jan 2016 06:53:39 +0000 (UTC) Received: from professor-x (S010634bdfa9ecf80.vc.shawcable.net [96.49.31.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: dolsen) by smtp.gentoo.org (Postfix) with ESMTPSA id 062CF33D3CE for ; Mon, 11 Jan 2016 06:53:39 +0000 (UTC) Date: Sun, 10 Jan 2016 22:52:46 -0800 From: Brian Dolbec To: gentoo-portage-dev@lists.gentoo.org Subject: Re: [gentoo-portage-dev] [Patch] Repoman rewrite stage2 modularization conversion complete Message-ID: <20160110225246.376db2f6.dolsen@gentoo.org> In-Reply-To: <20160110142851.56e5e80c.dolsen@gentoo.org> References: <20160110134008.4fce78c0.dolsen@gentoo.org> <20160110142851.56e5e80c.dolsen@gentoo.org> Organization: Gentoo Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Archives-Salt: 6d3ab07d-6dcd-4837-bc55-43ac1028e15e X-Archives-Hash: 5a26447cb9fc6ac9dec4fcbaa8ef3ddb On Sun, 10 Jan 2016 14:28:51 -0800 Brian Dolbec wrote: > On Sun, 10 Jan 2016 13:40:08 -0800 > Brian Dolbec wrote: > > > I have now pushed a fully rebased, properly sequenced commit > > history to the repoman branch. To be honest I think all the > > rebasing, re-testing took as much time as the initial conversion > > and testing. Anyway, I consider the branch now ready for final > > review. Since there are a total of 45 commits. I am not sending > > them to the list at this time. They are available for review via > > the repoman branch at > > > > https://gitweb.gentoo.org/proj/portage.git/log/?h=repoman > > > > https://github.com/gentoo/portage/commits/repoman > > > > or github pull request for commit order convienience > > > > https://github.com/gentoo/portage/pull/22 > > > > But please try to follow our standard rules and reply with any > > comments or code review to this email thread. > > OK, There are 2 test failures I need to fix. The patch to the plugin > system seems to have broken emaint. Also there is one repoman test > failure which is I think related to the metadata.dtd url change. > I've fixed and rebased in the emaint breakage. As for the repoman test failure. The test data set up for test_simple has None as the vcs type. When I added code to get past the vcs_preserves_mtime check. It then fails for the ${VCS}changes file and class. So, it looks like I need to create a "None" vcs plugin. Then it will handle all info/functions just like any of the real vcs types. This is a side effect of spltting up the code from if cvs in ('foo', 'bar')... code into self directing code for the vcs type. -- Brian Dolbec