From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 3602C1388B6 for ; Tue, 5 Jan 2016 09:43:56 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 72457E080C; Tue, 5 Jan 2016 09:43:55 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id F0003E07F9 for ; Tue, 5 Jan 2016 09:43:53 +0000 (UTC) Received: from professor-x (S010634bdfa9ecf80.vc.shawcable.net [96.49.31.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: dolsen) by smtp.gentoo.org (Postfix) with ESMTPSA id 21CAE3408EE for ; Tue, 5 Jan 2016 09:43:53 +0000 (UTC) Date: Tue, 5 Jan 2016 01:43:03 -0800 From: Brian Dolbec To: gentoo-portage-dev@lists.gentoo.org Subject: Re: [gentoo-portage-dev] [PATCH] repoman: filter out duplicate dependencies in error messages Message-ID: <20160105014303.6db2f3cf.dolsen@gentoo.org> In-Reply-To: <20160104191741.0cc3c8a3.dolsen@gentoo.org> References: <1451943030-20380-1-git-send-email-vapier@gentoo.org> <20160104191741.0cc3c8a3.dolsen@gentoo.org> Organization: Gentoo Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Archives-Salt: 6a446301-9a33-4f1e-8136-6a88b4590e0b X-Archives-Hash: 8b00de856d0b4f0562b40c9e025ff27d On Mon, 4 Jan 2016 19:17:41 -0800 Brian Dolbec wrote: > On Mon, 4 Jan 2016 16:30:30 -0500 > Mike Frysinger wrote: > > > Some packages list the same atom multiple times (e.g. behind diff > > USE flags). If one of them throws an error, we end up listing it > > more than once, and the output can get verbose/useless. > > --- > > pym/repoman/scanner.py | 13 +++++++++++-- > > 1 file changed, 11 insertions(+), 2 deletions(-) > > > > diff --git a/pym/repoman/scanner.py b/pym/repoman/scanner.py > > index d1c10d7..94ada90 100644 > > --- a/pym/repoman/scanner.py > > +++ b/pym/repoman/scanner.py > > @@ -704,13 +704,22 @@ class Scanner(object): > > > > # > > we have some unsolvable deps # remove ! deps, which always show up > > as unsatisfiable > > - > > atoms = [ > > + > > all_atoms = [ str(atom.unevaluated_atom) > > for > > atom in atoms if not atom.blocker] > > # > > if we emptied out our list, continue: > > - if > > not atoms: > > + if > > not all_atoms: continue > > + > > + # > > Filter out duplicates. We do this by hand (rather > > + # > > than use a set) so the order is stable and better > > + # > > matches the order that's in the ebuild itself. > > + > > atoms = [] > > + for > > atom in all_atoms: > > + > > if atom not in atoms: > > + > > atoms.append(atom) + > > if > > self.options.output_style in ['column']: > > self.qatracker.add_error(mykey, "%s: %s: %s(%s) %s" > > > I immediately want to say REJECT!, REJECT!, REJECT!,... > > I just spent a marathon week working on stage2 of the repoman rewrite. > looks like this is now the pym/repoman/modules/scan/depend/profile.py check -- Brian Dolbec