Re: [gentoo-portage-dev] [PATCH] postsync: skip hooks and metadata-transfer when appropriate (bug 564988)

[Brian Dolbec <dolsen@gentoo.org>]

On Fri, 6 Nov 2015 09:20:45 +0100
Alexander Berntsen <bernalex@gentoo.org> wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA512
> 
> On 06/11/15 09:05, Michał Górny wrote:
> >>> I know nothing about the egencache stuff. Maybe Michał can
> >>> comment?  
> > Michał finds this black magic. Trusts zmedico.  
> I think it looks like it's probably supposed to be reasonable,
> perhaps.
> 
> Maybe Brian can look at it. At least that way we'll have a lot of
> people that attempted understanding what's going on.
> 
> Maybe we need a "Trusted-by:" line.
> - -- 
> Alexander
> bernalex@gentoo.org


Well, the changes look pretty straight forward.  I thought we had
handled not updating the caches/ running postsync hooks if it didn't
sync, but Zac obviously found one that slipped through.

Seeing the patch only doesn't give an entirely clear picture of the
changes.   For that you would have to read the code and the changes in
the code to figure them all out.  But I too trust Zac, and I don't
feel this is complex and critical enough to warrant the time needed to
study all the changes.  I know he's tested the code ;)

But I thought I saw a typo when you used BOOLEAN1 |= BOOLEAN2.  I'd
never seen the | used like that.  It is nearly impossible to find any
docs/examples of it.  But I did find it as a bitwise or on integers
which boolean is a special form of.  Interesting that it is equivalent
to a = max(a,b) 



-- 
Brian Dolbec <dolsen>