From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 99AC713888F for ; Wed, 28 Oct 2015 13:29:24 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 2E32721C02F; Wed, 28 Oct 2015 13:29:21 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id A5FEA21C028 for ; Wed, 28 Oct 2015 13:29:20 +0000 (UTC) Received: from professor-x (S010634bdfa9ecf80.vc.shawcable.net [96.49.31.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: dolsen) by smtp.gentoo.org (Postfix) with ESMTPSA id 74D48340B1F for ; Wed, 28 Oct 2015 13:29:18 +0000 (UTC) Date: Wed, 28 Oct 2015 06:28:27 -0700 From: Brian Dolbec To: gentoo-portage-dev@lists.gentoo.org Subject: Re: [gentoo-portage-dev] [PATCH] RepoConfigLoader: allow subsitution of variables like ROOT in repos.conf Message-ID: <20151028062827.2568a797.dolsen@gentoo.org> In-Reply-To: <1445564163-27294-1-git-send-email-zmedico@gentoo.org> References: <1445538549.31293.104.camel@transmode.se> <1445564163-27294-1-git-send-email-zmedico@gentoo.org> Organization: Gentoo Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-portage-dev@lists.gentoo.org Reply-to: gentoo-portage-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Archives-Salt: 34408323-77a0-4430-ad8a-817791a8f32d X-Archives-Hash: 2b5891f251871486e5011712d33b271a On Thu, 22 Oct 2015 18:36:03 -0700 Zac Medico wrote: > This makes it possible to sync repositories inside $ROOT. > > X-Gentoo-Bug: 563836 > X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=563836 > --- > pym/portage/repository/config.py | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/pym/portage/repository/config.py > b/pym/portage/repository/config.py index a90a994..1060bc7 100644 > --- a/pym/portage/repository/config.py > +++ b/pym/portage/repository/config.py > @@ -620,7 +620,12 @@ class RepoConfigLoader(object): > treemap = {} > ignored_map = {} > ignored_location_map = {} > - default_opts = {} > + default_opts = { > + "EPREFIX" : settings["EPREFIX"], > + "EROOT" : settings["EROOT"], > + "PORTAGE_CONFIGROOT" : > settings["PORTAGE_CONFIGROOT"], > + "ROOT" : settings["ROOT"], > + } > > if "PORTAGE_REPOSITORIES" in settings: > portdir = "" This looks good to me. -- Brian Dolbec