public inbox for gentoo-portage-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Brian Dolbec <dolsen@gentoo.org>
To: gentoo-portage-dev@lists.gentoo.org
Subject: Re: [gentoo-portage-dev] [PATCH] RepoConfigLoader: allow subsitution of variables like ROOT in repos.conf
Date: Wed, 28 Oct 2015 06:28:27 -0700	[thread overview]
Message-ID: <20151028062827.2568a797.dolsen@gentoo.org> (raw)
In-Reply-To: <1445564163-27294-1-git-send-email-zmedico@gentoo.org>

On Thu, 22 Oct 2015 18:36:03 -0700
Zac Medico <zmedico@gentoo.org> wrote:

> This makes it possible to sync repositories inside $ROOT.
> 
> X-Gentoo-Bug: 563836
> X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=563836
> ---
>  pym/portage/repository/config.py | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/pym/portage/repository/config.py
> b/pym/portage/repository/config.py index a90a994..1060bc7 100644
> --- a/pym/portage/repository/config.py
> +++ b/pym/portage/repository/config.py
> @@ -620,7 +620,12 @@ class RepoConfigLoader(object):
>  		treemap = {}
>  		ignored_map = {}
>  		ignored_location_map = {}
> -		default_opts = {}
> +		default_opts = {
> +			"EPREFIX" : settings["EPREFIX"],
> +			"EROOT" : settings["EROOT"],
> +			"PORTAGE_CONFIGROOT" :
> settings["PORTAGE_CONFIGROOT"],
> +			"ROOT" : settings["ROOT"],
> +		}
>  
>  		if "PORTAGE_REPOSITORIES" in settings:
>  			portdir = ""


This looks good to me.
-- 
Brian Dolbec <dolsen>



      reply	other threads:[~2015-10-28 13:29 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-21 16:47 [gentoo-portage-dev] @sets and @profile does not work when ROOT=PORTAGE_CONFIGROOT=/my/new/root Joakim Tjernlund
2015-10-22  4:35 ` Zac Medico
2015-10-22  7:05   ` Joakim Tjernlund
2015-10-22 15:54     ` Zac Medico
2015-10-22 18:29       ` Joakim Tjernlund
2015-10-22 18:54         ` Zac Medico
2015-10-22 19:16           ` Joakim Tjernlund
2015-10-22 19:25             ` Zac Medico
2015-10-22 20:54               ` Joakim Tjernlund
2015-10-22 21:08                 ` Zac Medico
2015-10-23  5:03           ` [gentoo-portage-dev] " Duncan
2015-10-23  9:21           ` [gentoo-portage-dev] " Joakim Tjernlund
2015-10-24 20:49             ` Zac Medico
2015-10-23  1:36         ` [gentoo-portage-dev] [PATCH] RepoConfigLoader: allow subsitution of variables like ROOT in repos.conf Zac Medico
2015-10-28 13:28           ` Brian Dolbec [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151028062827.2568a797.dolsen@gentoo.org \
    --to=dolsen@gentoo.org \
    --cc=gentoo-portage-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox